Skip to content

Use numeric literals for BYTES_PER_ELEMENT #59567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lionel-rowe wants to merge 4 commits into
base: main
Choose a base branch
from
+248 −248
Open

Use numeric literals for BYTES_PER_ELEMENT #59567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72142d6
Use numeric literals for BYTES_PER_ELEMENT
lionel-rowe Aug 9, 2024
16c3bb2
Merge branch 'main' into pr-59567
jakebailey Feb 6, 2026
7cb29ca
Merge branch 'main' into pr-59567
jakebailey Feb 6, 2026
aac526d
Mismerged file
jakebailey Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/lib/es2020.bigint.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ declare var BigInt: BigIntConstructor;
*/
interface BigInt64Array<TArrayBuffer extends ArrayBufferLike = ArrayBufferLike> {
/** The size in bytes of each element in the array. */
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 8;

/** The ArrayBuffer instance referenced by the array. */
readonly buffer: TArrayBuffer;
Expand Down Expand Up @@ -377,7 +377,7 @@ interface BigInt64ArrayConstructor {
new (array: ArrayLike<bigint> | ArrayBuffer): BigInt64Array<ArrayBuffer>;

/** The size in bytes of each element in the array. */
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 8;

/**
* Returns a new array from a set of elements.
Expand Down Expand Up @@ -421,7 +421,7 @@ declare var BigInt64Array: BigInt64ArrayConstructor;
*/
interface BigUint64Array<TArrayBuffer extends ArrayBufferLike = ArrayBufferLike> {
/** The size in bytes of each element in the array. */
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 8;

/** The ArrayBuffer instance referenced by the array. */
readonly buffer: TArrayBuffer;
Expand Down Expand Up @@ -668,7 +668,7 @@ interface BigUint64ArrayConstructor {
new (array: ArrayLike<bigint> | ArrayBuffer): BigUint64Array<ArrayBuffer>;

/** The size in bytes of each element in the array. */
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 8;

/**
* Returns a new array from a set of elements.
Expand Down
4 changes: 2 additions & 2 deletions src/lib/es2025.float16.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ interface Float16Array<TArrayBuffer extends ArrayBufferLike = ArrayBufferLike> {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 2;

/**
* The ArrayBuffer instance referenced by the array.
Expand Down Expand Up @@ -362,7 +362,7 @@ interface Float16ArrayConstructor {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 2;

/**
* Returns a new array from a set of elements.
Expand Down
36 changes: 18 additions & 18 deletions src/lib/es5.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1866,7 +1866,7 @@ interface Int8Array<TArrayBuffer extends ArrayBufferLike = ArrayBufferLike> {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 1;

/**
* The ArrayBuffer instance referenced by the array.
Expand Down Expand Up @@ -2116,7 +2116,7 @@ interface Int8ArrayConstructor {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 1;

/**
* Returns a new array from a set of elements.
Expand Down Expand Up @@ -2148,7 +2148,7 @@ interface Uint8Array<TArrayBuffer extends ArrayBufferLike = ArrayBufferLike> {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 1;

/**
* The ArrayBuffer instance referenced by the array.
Expand Down Expand Up @@ -2398,7 +2398,7 @@ interface Uint8ArrayConstructor {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 1;

/**
* Returns a new array from a set of elements.
Expand Down Expand Up @@ -2430,7 +2430,7 @@ interface Uint8ClampedArray<TArrayBuffer extends ArrayBufferLike = ArrayBufferLi
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 1;

/**
* The ArrayBuffer instance referenced by the array.
Expand Down Expand Up @@ -2680,7 +2680,7 @@ interface Uint8ClampedArrayConstructor {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 1;

/**
* Returns a new array from a set of elements.
Expand Down Expand Up @@ -2712,7 +2712,7 @@ interface Int16Array<TArrayBuffer extends ArrayBufferLike = ArrayBufferLike> {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 2;

/**
* The ArrayBuffer instance referenced by the array.
Expand Down Expand Up @@ -2961,7 +2961,7 @@ interface Int16ArrayConstructor {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 2;

/**
* Returns a new array from a set of elements.
Expand Down Expand Up @@ -2993,7 +2993,7 @@ interface Uint16Array<TArrayBuffer extends ArrayBufferLike = ArrayBufferLike> {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 2;

/**
* The ArrayBuffer instance referenced by the array.
Expand Down Expand Up @@ -3243,7 +3243,7 @@ interface Uint16ArrayConstructor {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 2;

/**
* Returns a new array from a set of elements.
Expand Down Expand Up @@ -3274,7 +3274,7 @@ interface Int32Array<TArrayBuffer extends ArrayBufferLike = ArrayBufferLike> {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 4;

/**
* The ArrayBuffer instance referenced by the array.
Expand Down Expand Up @@ -3524,7 +3524,7 @@ interface Int32ArrayConstructor {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 4;

/**
* Returns a new array from a set of elements.
Expand Down Expand Up @@ -3556,7 +3556,7 @@ interface Uint32Array<TArrayBuffer extends ArrayBufferLike = ArrayBufferLike> {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 4;

/**
* The ArrayBuffer instance referenced by the array.
Expand Down Expand Up @@ -3805,7 +3805,7 @@ interface Uint32ArrayConstructor {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 4;

/**
* Returns a new array from a set of elements.
Expand Down Expand Up @@ -3837,7 +3837,7 @@ interface Float32Array<TArrayBuffer extends ArrayBufferLike = ArrayBufferLike> {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 4;

/**
* The ArrayBuffer instance referenced by the array.
Expand Down Expand Up @@ -4087,7 +4087,7 @@ interface Float32ArrayConstructor {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 4;

/**
* Returns a new array from a set of elements.
Expand Down Expand Up @@ -4119,7 +4119,7 @@ interface Float64Array<TArrayBuffer extends ArrayBufferLike = ArrayBufferLike> {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 8;

/**
* The ArrayBuffer instance referenced by the array.
Expand Down Expand Up @@ -4369,7 +4369,7 @@ interface Float64ArrayConstructor {
/**
* The size in bytes of each element in the array.
*/
readonly BYTES_PER_ELEMENT: number;
readonly BYTES_PER_ELEMENT: 8;

/**
* Returns a new array from a set of elements.
Expand Down
16 changes: 8 additions & 8 deletions tests/baselines/reference/es2024SharedMemory.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ const sab = new SharedArrayBuffer(Int32Array.BYTES_PER_ELEMENT * 1024);
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>Int32Array.BYTES_PER_ELEMENT * 1024 : number
> : ^^^^^^
>Int32Array.BYTES_PER_ELEMENT : number
> : ^^^^^^
>Int32Array.BYTES_PER_ELEMENT : 4
> : ^
>Int32Array : Int32ArrayConstructor
> : ^^^^^^^^^^^^^^^^^^^^^
>BYTES_PER_ELEMENT : number
> : ^^^^^^
>BYTES_PER_ELEMENT : 4
> : ^
>1024 : 1024
> : ^^^^

Expand All @@ -42,12 +42,12 @@ const sab64 = new SharedArrayBuffer(BigInt64Array.BYTES_PER_ELEMENT * 1024);
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>BigInt64Array.BYTES_PER_ELEMENT * 1024 : number
> : ^^^^^^
>BigInt64Array.BYTES_PER_ELEMENT : number
> : ^^^^^^
>BigInt64Array.BYTES_PER_ELEMENT : 8
> : ^
>BigInt64Array : BigInt64ArrayConstructor
> : ^^^^^^^^^^^^^^^^^^^^^^^^
>BYTES_PER_ELEMENT : number
> : ^^^^^^
>BYTES_PER_ELEMENT : 8
> : ^
>1024 : 1024
> : ^^^^

Expand Down
16 changes: 8 additions & 8 deletions tests/baselines/reference/sharedMemory.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ const sab = new SharedArrayBuffer(Int32Array.BYTES_PER_ELEMENT * 1024);
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>Int32Array.BYTES_PER_ELEMENT * 1024 : number
> : ^^^^^^
>Int32Array.BYTES_PER_ELEMENT : number
> : ^^^^^^
>Int32Array.BYTES_PER_ELEMENT : 4
> : ^
>Int32Array : Int32ArrayConstructor
> : ^^^^^^^^^^^^^^^^^^^^^
>BYTES_PER_ELEMENT : number
> : ^^^^^^
>BYTES_PER_ELEMENT : 4
> : ^
>1024 : 1024
> : ^^^^

Expand All @@ -38,12 +38,12 @@ const sab64 = new SharedArrayBuffer(BigInt64Array.BYTES_PER_ELEMENT * 1024);
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>BigInt64Array.BYTES_PER_ELEMENT * 1024 : number
> : ^^^^^^
>BigInt64Array.BYTES_PER_ELEMENT : number
> : ^^^^^^
>BigInt64Array.BYTES_PER_ELEMENT : 8
> : ^
>BigInt64Array : BigInt64ArrayConstructor
> : ^^^^^^^^^^^^^^^^^^^^^^^^
>BYTES_PER_ELEMENT : number
> : ^^^^^^
>BYTES_PER_ELEMENT : 8
> : ^
>1024 : 1024
> : ^^^^

Expand Down
Loading