Fix startup crash when redefining global Array with @noLib#63179
Open
hayatexe wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix startup crash when redefining global Array with @noLib#63179hayatexe wants to merge 1 commit intomicrosoft:mainfrom
hayatexe wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57009
Description
When
--noLibis specified and a user statically re-definesArraythrough a generic type alias (e.g.type Array<T> = T[]), attempting to build the program causes the compiler to hit a crash early in the startup phase.The issue occurred because the
globalArrayTypeis resolved dynamically viagetGlobalType. In--noLibscenarios, the alias forArraymatches the global type, invoking type resolution to load the Array's target type beforeglobalArrayTypehas finished initializing. When evaluatingT[],getArrayOrTupleTargetTypeis called and tries to returnglobalArrayType(which is stillundefined). This causedtargetinsidegetTypeFromArrayOrTupleTypeNodeto beundefined, which subsequently crashed oncreateDeferredTypeReference(target, ...)because it accessedtarget.symbol.This PR fixes the crash by explicitly letting
getArrayOrTupleTargetTypefallback toemptyGenericTypeinstead of returningundefined. This resolves the dependency cycle cleanly and causes the checker to produce expected diagnostic errors (Global type 'Array' must have 1 type parameter(s)) instead of crashing the process.A regression test is included.