fix: allow percent-encoded sourceBase path segments - #2584
Draft
Aryan Singh K. (aryansk) wants to merge 1 commit into
Draft
fix: allow percent-encoded sourceBase path segments#2584Aryan Singh K. (aryansk) wants to merge 1 commit into
Aryan Singh K. (aryansk) wants to merge 1 commit into
Conversation
|
Aryan Singh K. (@aryansk) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
|
any chance you could also add support for these URL encoded paths in a remote repo source as well? name: my-name
version: 0.1.0
description: description
author: author
dependencies:
apm: []
mcp: []
includes: auto
scripts: {}
marketplace:
owner:
name: name
url: url
outputs:
claude: {}
packages:
- name: my-skill
source: https://dev.azure.com/myorg/My%20Projects/_git/reponame
ref: main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow valid percent-encoded bytes in marketplace
sourceBasepath segments so Azure DevOps project names such asMy%20Projectswork.Changes
%HHsequences in thesourceBase-specific path grammar without loosening package source validation%20project name and encoded traversal/separator casesValidation
Adds focused schema tests for the reported Azure DevOps URL and for encoded traversal safety.
Fixes #2554