Skip to content

perf: partition remote refs in one pass #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Aryan Singh K. (aryansk) wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf: partition remote refs in one pass #2586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/apm_cli/deps/git_remote_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,13 @@ def semver_sort_key(name: str):

def sort_remote_refs(refs: list[RemoteRef]) -> list[RemoteRef]:
"""Sort refs: tags first (semver descending), then branches alphabetically."""
tags = [r for r in refs if r.ref_type == GitReferenceType.TAG]
branches = [r for r in refs if r.ref_type == GitReferenceType.BRANCH]
tags: list[RemoteRef] = []
branches: list[RemoteRef] = []
for ref in refs:
if ref.ref_type == GitReferenceType.TAG:
tags.append(ref)
elif ref.ref_type == GitReferenceType.BRANCH:
branches.append(ref)
tags.sort(key=lambda r: semver_sort_key(r.name))
branches.sort(key=lambda r: r.name)
return tags + branches