fix: keep global install dry-run out of user state - #2592
Draft
Aryan Singh K. (aryansk) wants to merge 1 commit into
Draft
fix: keep global install dry-run out of user state#2592Aryan Singh K. (aryansk) wants to merge 1 commit into
Aryan Singh K. (aryansk) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
apm install --dry-run -gtruly read-only when bootstrapping a user-scope manifest.Changes
ensure_user_dirs()during dry-runapm.ymlto temporary storage so validation and planning can still parse a manifestfinallypath~/.apmValidation
Prepared focused regression tests:
pytest -q tests/unit/regressions/test_issue_2549_global_dry_run.pyPatch structure was validated with
git apply --check. Full repository tests should run in CI.Fixes #2549