feat: add `find` command for catalog search#174

Open

nadavs123 wants to merge 66 commits intomicrosoft:mainfrom

nadavs123:feature/catalog-search-find-command

Commits on Apr 15, 2026

Add fab find command for catalog search API
Nadav Schachter
committed
feat(find): address feedback - nargs+, remove endpoint, add error handling
Nadav Schachter
committed
feat(find): add tab-completion for --type flag
Nadav Schachter
committed
feat(find): add --limit validation (1-1000)
Nadav Schachter
committed
feat(find): use custom validation for cleaner error messages
Nadav Schachter
committed
fix(find): fix API integration issues
Nadav Schachter
committed
fix(find): correct print_output_format call for table display
Nadav Schachter
committed
feat(find): add key-value layout for --detailed flag
Nadav Schachter
committed
refactor(find): change --detailed to -l/--long to match CLI convention
Nadav Schachter
committed
feat(find): hide empty keys in long output
Nadav Schachter
committed
refactor(find): reorder long output fields (name, id, type, workspace, workspace_id, description)
Nadav Schachter
committed
feat(find): add blank line separator before results
Nadav Schachter
committed
feat(find): add blank line before count message
Nadav Schachter
committed
feat(find): add --continue flag for pagination
Nadav Schachter
committed
fix(find): fix --continue to not duplicate search/filter params
Nadav Schachter
committed
refactor(find): rename flags to --max-items and --next-token
Nadav Schachter
committed
feat(find): hide description column when all descriptions are empty
Nadav Schachter
committed
fix(find): remove Scorecard from unsupported types (returned as Report)
Nadav Schachter
committed
fix(find): remove Dataflow from unsupported types (Gen2 CI/CD is searchable)
Nadav Schachter
committed
docs(find): clarify Dataflow Gen1/Gen2 are not searchable
Nadav Schachter
committed
docs(find): add 'currently' to Dataflow note
Nadav Schachter
committed
refactor(find): replace --next-token/--type/--max-items with auto-pagination and -P params

Nadav Schachter
and
Copilot
committed
test(find): update tests for pagination and -P params refactor

Nadav Schachter
and
Copilot
committed
fix(find): make -P type filter case-insensitive
Nadav Schachter
committed
fix(find): treat empty continuation token as end of results

Nadav Schachter
and
Copilot
committed
fix(find): truncate descriptions to fit terminal width

Nadav Schachter
and
Copilot
committed
feat(find): paginate all results in command-line mode

Nadav Schachter
and
Copilot
committed
fix(find): improve error messages per Microsoft Writing Style Guide

Nadav Schachter
and
Copilot
committed
Delete issue-172.md

nadavs123
authored and
Nadav Schachter
committed
Address PR #174 review feedback

Nadav Schachter
and
Copilot
committed
Add e2e VCR test skeleton for find command

Nadav Schachter
and
Copilot
committed
fix: patch PromptSession before singleton instantiation on Windows

Nadav Schachter
and
Copilot
committed
fix: e2e tests — mock input, normalize cassette URLs, fix assertions

Nadav Schachter
and
Copilot
committed
test: remove TestFindCommandline and TestFindInteractive (covered by e2e)

Nadav Schachter
and
Copilot
committed
refactor: use table output for -l instead of key-value list

Nadav Schachter
and
Copilot
committed
docs: update find.md for table-based -l output

Nadav Schachter
and
Copilot
committed
Address round 2 review: adopt get_dict_from_params, common errors, test improvements

Nadav Schachter
and
Copilot
committed
Convert unit tests to e2e: param validation and JMESPath

Nadav Schachter
and
Copilot
committed
Expand e2e coverage, remove redundant unit tests

Nadav Schachter
and
Copilot
committed
Address round 3 review: max_depth, cassette sanitization, config cleanup

Nadav Schachter
and
Copilot
committed
Add forward-compatible workspace hierarchy parsing

Nadav Schachter
and
Copilot
committed
Smart column truncation and running total for pagination

Nadav Schachter
and
Copilot
committed
Address review rounds 3-4: restructure tests, source improvements

Nadav Schachter
and
Copilot
committed
Polish: pagination, summary count, error hints, empty line after table

Nadav Schachter
and
Copilot
committed
Address PR review: fix bugs, packaging, and code quality

Nadav Schachter
and
Copilot
committed
Simplify search status message to 'Searching...'

Nadav Schachter
and
Copilot
committed
Tighten fab_find: simplify filter builder, dedup pagination, remove dead code

Nadav Schachter
and
Copilot
committed
Address reviewer feedback: loops, _parse_response, output_format

Nadav Schachter
and
Copilot
committed
Address Copilot review: truncation in fab_ui, padding fix, UTF-8

Nadav Schachter
and
Copilot
committed

Commits on Apr 16, 2026

refactor: restructure fetch loops and handle empty JMESPath results

Nadav Schachter
and
Copilot
committed
Refine _display_page helper and add pagination e2e tests

Nadav Schachter
and
Copilot
committed
Skip synthetic cassette tests during VCR re-recording

Nadav Schachter
and
Copilot
committed

Commits on Apr 17, 2026

Re-record VCR cassettes with scrubbed tenant data

Nadav Schachter
and
Copilot
committed
Remove unused imports in test_find.py

Nadav Schachter
and
Copilot
committed

Commits on Apr 19, 2026

Round 7 PR review fixes for fab find

Nadav Schachter
and
Copilot
committed
Move find truncation gating into print_output_format

Nadav Schachter
and
Copilot
committed
Add truncation tests for long display names

Nadav Schachter
and
Copilot
committed
Fix output format None crash when config is unset

Nadav Schachter
and
Copilot
committed
Guard truncate_columns against non-dict list items

Nadav Schachter
and
Copilot
committed

Commits on Apr 20, 2026

Merge branch 'main' into feature/catalog-search-find-command
nadavs123
authored
Remove or text fallback from format_type resolution

Nadav Schachter
and
Copilot
committed
Fix mypy type errors in fab_find

Nadav Schachter
and
Copilot
committed
Replace asserts with guard breaks for type narrowing

Nadav Schachter
and
Copilot
committed
Widen _next_page_payload signature to accept str | None

Nadav Schachter
and
Copilot
committed
Drive pagination loops from continuation_token directly

Nadav Schachter
and
Copilot
committed
Align truncate_columns field set with text table renderer

Nadav Schachter
and
Copilot
committed