Repository navigation
fix: use Highlight/HighlightText for MenuItem hover - #36974
Open
Victor Genaev (mainframev) wants to merge 1 commit into
Open
Victor Genaev (mainframev) wants to merge 1 commit into
Victor Genaev (mainframev) wants to merge 1 commit into
Conversation
…states in forced colors mode
Victor Genaev (mainframev)
changed the title
Victor Genaev (mainframev)
marked this pull request as ready for review
October 22, 2026 01:47
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
In forced colors mode, a hovered
MenuItemkept itsCanvasbackground and only the label turnedHighlight. This affects every item that shares these styles: checkbox, radio, link, switch and split. TheborderColor: 'Highlight'rule did nothing, because the item has no border. The icon, checkmark, secondary content and subtext kept their token colors, which forced colors maps toCanvasText. The open-submenu state had the same problem.New Behavior
Hovered and open-submenu items get a
Highlightbackground, withHighlightTexton the item and all of its slots.forcedColorAdjust: 'none'. Without it, Chromium paints aCanvasbackplate behind the text and the label shows as a black box on theHighlightbackground. Tab and InteractionTag do the same.CanvasandGrayTexton hover. They resetforcedColorAdjusttoauto, and the checkmark and secondary content now followGrayTexttoo.Screenshots: Chromium forced-colors emulation (
emulateMedia({ forcedColors: 'active' })) on the MenuList Default, Checkbox items and Nested submenus stories