Repository navigation
fix(react-headless-components-preview): emit data-disabled on ImageSwatch - #36979
Merged
Victor Genaev (mainframev) merged 1 commit intoOct 22, 2026
Conversation
…atch ColorSwatch and EmptySwatch expose data-disabled for styling, but ImageSwatch only set data-selected, so consumers had to fall back to :disabled or add the attribute themselves.
Victor Genaev (mainframev)
force-pushed
the
fix/headless-image-swatch-data-disabled
branch
from
October 22, 2026 11:30
64986da to
44cd511
Compare
Victor Genaev (mainframev)
marked this pull request as ready for review
October 22, 2026 11:30
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
Paul Mardling (PaulGMardling)
approved these changes
Oct 22, 2026
Paul Mardling (PaulGMardling)
left a comment
Paul Mardling (PaulGMardling)
left a comment
Contributor
There was a problem hiding this comment.
Looks good!
Victor Genaev (mainframev)
merged commit Oct 22, 2026
e7c9873
into
microsoft:master
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
ImageSwatchset onlydata-selected(andfocusgroupstart) on its root. A disabled image swatch had nodata-disabled, unlikeColorSwatchandEmptySwatch, so styling layers had to fall back to:disabledor add the attribute themselves.New Behavior
useImageSwatchsetsdata-disabledfrom thedisabledprop (present when true, absent otherwise), matchingColorSwatch.ImageSwatchStateand the API report include the new root attribute. A unit test covers the disabled and enabled cases