Support ML-KEM with OpenSSL 3.3 - #2492
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
It updates a large, security-sensitive vendored crypto backend (including regenerated OpenSSL shims), which warrants careful human validation/testing across supported OpenSSL versions.
Review tier: Lite
Findings: None
What changed in this PR
Updates the vendored github.com/microsoft/go-crypto-openssl backend to a newer revision to support ML-KEM when running against OpenSSL 3.3, and adjusts the vendor patch to match the updated upstream backend codegen/API usage.
Changes:
- Bumps
github.com/microsoft/go-crypto-openssltov0.5.1-0.20260904065618-5fd04832939dand updatesgo.sum/modules.txtaccordingly. - Switches OpenSSL 3 key construction paths from numeric EVP/NID identifiers to algorithm name strings (via
EVP_PKEY_CTX_new_from_name) for ML-KEM/ML-DSA and related EVP-from-params helpers. - Regenerates vendored OpenSSL shim bindings (
shims.h/zossl*) to includeEVP_PKEY_CTX_new_from_nameand remove hardcoded ML-KEM/ML-DSA numeric constants.
Patches are happy!
| File | Description |
|---|---|
| patches/0001-Vendor-external-dependencies.patch | Updates the vendor patch to the newer go-crypto-openssl revision and corresponding generated OpenSSL shim/binding changes needed for OpenSSL 3.3 ML-KEM support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Davis Goodin (dagood)
approved these changes
Sep 4, 2026
George Adams (gdams)
approved these changes
Sep 4, 2026
George Adams (gdams)
enabled auto-merge (squash)
September 4, 2026 07:32
George Adams (gdams)
added a commit
that referenced
this pull request
Sep 4, 2026
Backport of #2492 to microsoft/release-branch.go1.27. Co-authored-by: qmuntal <quimmuntal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the OpenSSL backend to bring microsoft/go-crypto-openssl#68.