pipeline: exclude stage 0 toolchain from Component Governance - #2494
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Quim Muntal (qmuntal)
approved these changes
Sep 4, 2026
George Adams (gdams)
enabled auto-merge (squash)
September 4, 2026 08:41
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is minimal, consistent across the generated and source pipeline YAML, and scoped to excluding a clearly non-shipping directory from Component Governance scanning.
Review tier: Lite
Findings: None
What changed in this PR
Updates the internal rolling pipeline configuration to exclude the temporary Stage 0 Go bootstrap toolchain directory from Component Governance scanning, preventing non-shipping toolchain vulnerabilities from being attributed to this repository.
Changes:
- Add
sdl.componentgovernance.ignoreDirectoriesto excludeeng/artifacts/_goStage0from CG scans. - Regenerate the corresponding rolling internal generated pipeline YAML to keep it in sync.
| File | Description |
|---|---|
| eng/pipeline/rolling-internal.gen.yml | Adds Component Governance ignore path for the Stage 0 bootstrap toolchain directory. |
| eng/pipeline/rolling-internal-pipeline.yml | Mirrors the CG ignore configuration in the non-generated rolling internal pipeline definition. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pwsh eng/run.ps1 pipelineymlgengit diff --check -- eng/pipeline/rolling-internal.gen.yml eng/pipeline/rolling-internal-pipeline.yml