Repository navigation
Upgrade OpenSSL backend - #2546
Merged
Merged
Conversation
Update go-crypto-openssl to the revision containing the merged ML-DSA allocation improvements. Synchronize the standalone cryptobackend requirement and regenerate the vendored dependency patch.
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
George Adams (gdams)
approved these changes
Oct 6, 2026
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: None
What changed in this PR
Upgrades the vendored OpenSSL crypto backend (github.com/microsoft/go-crypto-openssl) to pick up ML-DSA allocation improvements and related upstream fixes, and synchronizes the standalone cryptobackend module metadata accordingly.
Changes:
- Bump
github.com/microsoft/go-crypto-openssltov0.5.1-0.20261005142555-824eae519d26in both std patch metadata andcryptobackend’sgo.mod/go.sum. - Regenerate patch
0001to reflect updated vendor contents (fakecgo layout updates, loader thread-affinity fix, TLS 1.2 PRF compatibility tweak).
| File | Description |
|---|---|
| patches/0001-Vendor-external-dependencies.patch | Updates the vendored dependency patch to the new go-crypto-openssl revision and includes upstream generated file changes. |
| cryptobackend/go.mod | Bumps the direct go-crypto-openssl requirement to the new pseudo-version. |
| cryptobackend/go.sum | Updates checksums to match the new go-crypto-openssl pseudo-version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
github.com/microsoft/go-crypto-openssltov0.5.1-0.20261005142555-824eae519d26, which includes the merged ML-DSA allocation improvements in microsoft/go-crypto-openssl#85. Synchronize the standalone cryptobackend requirement and regenerate the vendored dependency patch.The upgrade also includes the provider's loader thread-affinity fix, fakecgo layout updates, and TLS 1.2 PRF compatibility change. This PR changes only the standalone module metadata and patch 0001; it does not include the separate ML-DSA fallback migration or change the Go submodule pointer.
The existing ML-DSA allocation workload drops from 28 to 8 Go allocations with the same Go toolchain, OpenSSL 3.5.7 provider and inputs. This does not measure native allocations or throughput.
Updates #2489.
Validation
GOEXPERIMENT=cgocheck2; shared-binding algorithm race tests passed.No E2E/replay suites or throughput benchmarks were run.