Repository navigation
Upgrade Darwin backend - #2547
Merged
Merged
Conversation
Update go-crypto-darwin to the revision containing the merged ML-DSA allocation improvements. Synchronize the standalone cryptobackend requirement and regenerate the vendored dependency patch.
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The native crypto upgrade includes precompiled objects and lacked native macOS execution validation.
Review effort: Balanced
Findings: None
What changed in this PR
Upgrades the Darwin crypto provider and synchronizes standalone and vendored dependency metadata.
Changes:
- Updates the Darwin provider version and checksums.
- Regenerates the vendor patch with ML-DSA allocation improvements and libc-path changes.
Patch consistency: Patches are happy!
| File | Description |
|---|---|
cryptobackend/go.mod |
Pins the upgraded Darwin provider. |
cryptobackend/go.sum |
Updates provider checksums. |
patches/0001-Vendor-external-dependencies.patch |
Synchronizes vendored Darwin sources and metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Quim Muntal (qmuntal)
enabled auto-merge
October 6, 2026 13:34
George Adams (gdams)
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
github.com/microsoft/go-crypto-darwintov0.0.3-0.20261006124332-ca950df3b0d1, which includes the merged ML-DSA allocation improvements in microsoft/go-crypto-darwin#257. Synchronize the standalone cryptobackend requirement and regenerate the vendored dependency patch.The revision also removes Darwin's fakecgo initialization in favor of the runtime-managed libc call path and updates the precompiled CryptoKit objects. This PR changes only the standalone module metadata and patch 0001; it does not include the separate ML-DSA fallback migration or change the Go submodule pointer.
The provider now calls CryptoKit ML-DSA bindings directly and borrows context bytes read-only. Its macOS 26 CI passes the existing-key allocation budgets in both cgo modes: signing at most one Go allocation for the returned signature, verification and equality zero. This does not measure native allocations or throughput, or the full standard-library ML-DSA workload.
Updates #2489.
Validation
Native macOS execution was not available locally. No E2E/replay suites or throughput benchmarks were run.