Add inflatelib_version - #28
Merged
Merged
Conversation
Dustin L. Howett (DHowett)
approved these changes
Aug 21, 2026
Dustin L. Howett (DHowett)
left a comment
Dustin L. Howett (DHowett)
left a comment
Member
There was a problem hiding this comment.
Ah, this all makes sense. Thanks!
We could conceivably simplify the version check to not use str* functions, but I'm not terribly worried about it
Member
Author
I was going to respond... then realized the custom loop is really quite simple |
Dustin L. Howett (DHowett)
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
inflatelib_versionto handle the scenarios where the version of the header used to compile a consumer against is not the same as the version of the library that it's linking against. I have also followed zlib's example of validating the major version inside the init function, failing if they differ.Two other small issues that I noticed:
/* ... */INFLATELIB_EXPORTrepeated, I'm pretty sure they do need the calling convention to match.