This repository was archived by the owner on Jan 27, 2021. It is now read-only.
Open
Conversation
|
|
Contributor
|
Hi Iddo, These changes don't pass the regression suite. To run the tests. do this: cd test This runs two separate suites. The test framework doesn't work on Windows because of the limitations of the Windows version of "pexpect", so you have to run them on Linux. Thanks -- Ken |
andjelatodorovic
approved these changes
Sep 15, 2019
andjelatodorovic
approved these changes
Oct 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using importlib rather than import, helps support in Windows.
In addition, IVy lexer supports Unicode (for ‘forall’, ‘exists’, ‘->’, etc.). It should not change anything else, since the whole text is converted to Unicode only in the lexer itself, and after lexing converted back. However, invalid Unicode characters are handled differently.