Harden for multi-scan JPEG#186
Open
nolmoonen wants to merge 4 commits into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
a67934a to
a69919a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176, #177, and an additional problem found for multi-scan JPEGs with multiple, different restart intervals. I've added tests for the error cases using CC0 images, and added a description for the JPEG properties. In order to holistically fix #177, I've also added support for multi-scan JPEG that are truncated within the scan, and added a test for this as well (
verify_encode_truncated_scan).read_first_scanandread_progressive_scanand have one functionread_scanthat reads any type of scan. The code was wrong here since it assumed that there can be no two initial DC scans in a JPEG.read_jpeg_fileallows the handling of garbage data to be the same for single- and multi-scan JPEGs.I realize that the PR is quite big, so please let me know if I can make any additional clarifications.