Move Azure specific services into the Azure core project#1722
Open
hallipr wants to merge 1 commit intomicrosoft:mainfrom
Open
Move Azure specific services into the Azure core project#1722hallipr wants to merge 1 commit intomicrosoft:mainfrom
hallipr wants to merge 1 commit intomicrosoft:mainfrom
Conversation
hallipr
requested review from
chidozieononiwu,
fanyang-mono,
jairmyree,
tmeschter,
vukelich and
wbreza
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves Azure-specific services (ResourceGroup, Subscription, and Tenant services) from the Microsoft.Mcp.Core project to the Azure.Mcp.Core project, along with their base classes (BaseAzureService and BaseAzureResourceService). This improves the architectural separation by keeping Azure-specific functionality in the Azure-specific core library.
Changes:
- Moved TenantService, SubscriptionService, and ResourceGroupService from Microsoft.Mcp.Core to Azure.Mcp.Core
- Moved BaseAzureService and BaseAzureResourceService base classes to Azure.Mcp.Core
- Updated service registration in both Azure.Mcp.Server and Fabric.Mcp.Server Program.cs files
- Moved UserAgentPolicy initialization from ServiceStartCommand to server-specific initialization
Reviewed changes
Copilot reviewed 5 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| servers/Fabric.Mcp.Server/src/Program.cs | Removed Azure-specific service registrations (ResourceGroupService, SubscriptionService, AddAzureTenantService) |
| servers/Azure.Mcp.Server/src/Program.cs | Added direct registrations for ResourceGroupService and SubscriptionService; moved UserAgentPolicy initialization to InitializeServicesAsync |
| core/Microsoft.Mcp.Core/src/Services/Azure/Authentication/IAzureTokenCredentialProvider.cs | Removed unused import |
| core/Microsoft.Mcp.Core/src/Areas/Server/Options/TransportTypes.cs | Changed class visibility from internal to public |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServiceStartCommand.cs | Removed UserAgentPolicy initialization (moved to server-specific code) |
| core/Azure.Mcp.Core/src/Services/Azure/Tenant/TenantServiceCollectionExtensions.cs | New extension method for registering TenantService with dependencies |
| core/Azure.Mcp.Core/src/Services/Azure/Tenant/TenantService.cs | New implementation of tenant management service |
| core/Azure.Mcp.Core/src/Services/Azure/Tenant/ITenantService.cs | New interface defining tenant service operations |
| core/Azure.Mcp.Core/src/Services/Azure/Subscription/SubscriptionService.cs | New implementation of subscription management service |
| core/Azure.Mcp.Core/src/Services/Azure/Subscription/ISubscriptionService.cs | New interface defining subscription service operations |
| core/Azure.Mcp.Core/src/Services/Azure/ResourceGroup/ResourceGroupService.cs | New implementation of resource group management service |
| core/Azure.Mcp.Core/src/Services/Azure/ResourceGroup/IResourceGroupService.cs | New interface defining resource group service operations |
| core/Azure.Mcp.Core/src/Services/Azure/BaseAzureService.cs | New base class for Azure services with user agent management and common utilities |
| core/Azure.Mcp.Core/src/Services/Azure/BaseAzureResourceService.cs | New base class for Azure resource management services with Resource Graph query support |
| { | ||
| ServiceStartOptions? options = serviceProvider.GetService<IOptions<ServiceStartOptions>>()?.Value; | ||
|
|
||
| if(options != null) |
There was a problem hiding this comment.
Missing space after if keyword. The code should be if (options != null) instead of if(options != null) for consistency with C# coding conventions.
Suggested change
| if(options != null) | |
| if (options != null) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves the Resource group, Subscription and Tenant services from the Micrcosoft.Mcp.Core project into the Azure.Mcp.Core project
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline