Change tool names to use dash instead of underscore

[conniey]

What does this PR do?

Changes tool names to use - instead of _ to follow naming rules in new-command.md. Updates:

• ai_app to ai-app
• azure_best_practices to azure-best-practices

Related #1592

GitHub issue number?

Fixes #1566

Pre-merge Checklist

• Required for All PRs
  • Read contribution guidelines
  • PR title clearly describes the change
  • Commit history is clean with descriptive messages (cleanup guide)
  • Added comprehensive tests for new/modified functionality
  • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
• For MCP tool changes:
  • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
  • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
  • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
  • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
  • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
  • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
  • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
  • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
• Extra steps for Azure MCP Server tool changes:
  • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
  • 👉 For Community (non-Microsoft team member) PRs:
    • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
    • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

[Copilot]

Pull request overview

This pull request changes tool names in the Azure Best Practices toolset from using underscores to dashes, aligning with the naming conventions documented in new-command.md. The changes affect two components: the area name "get_azure_bestpractices" becomes "get-azure-bestpractices", and the command name "ai_app" becomes "ai-app".

Changes:

• Changed area name from "get_azure_bestpractices" to "get-azure-bestpractices" in AzureBestPracticesSetup.cs
• Changed command name from "ai_app" to "ai-app" in AIAppBestPracticesCommand.cs

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
tools/Azure.Mcp.Tools.AzureBestPractices/src/AzureBestPracticesSetup.cs	Updates area name to use dashes instead of underscores, affecting both commands in this area
tools/Azure.Mcp.Tools.AzureBestPractices/src/Commands/AIAppBestPracticesCommand.cs	Updates command name to use dashes instead of underscores

[Copilot]

The tool name change from "ai_app" to "ai-app" requires updates to several other files that were not included in this PR. The full tool name uses the pattern: {area_name}{command_name}, where underscore is the separator (CommandFactory.Separator = ''). Since the area name is "get-azure-bestpractices" and the command name is now "ai-app", the full tool name should be "get-azure-bestpractices_ai-app".

The following files still reference the old tool name and need to be updated:

1. consolidated-tools.json (line 1073): "get_azure_bestpractices_ai_app" → "get-azure-bestpractices_ai-app"
2. prompts.json (line 546): Key "get_azure_bestpractices_ai_app" → "get-azure-bestpractices_ai-app"
3. azmcp-commands.md (lines 1516, 1519): "ai_app" → "ai-app"
4. e2eTestPrompts.md (lines 530-534): "get_azure_bestpractices_ai_app" → "get-azure-bestpractices_ai-app"
5. AIAppBestPracticesCommandTests.cs (line 60): The assertion expects "ai_app" but should expect "ai-app"

All references must be updated to maintain consistency and ensure the tool can be properly invoked.

[Copilot]

The area name change from "get_azure_bestpractices" to "get-azure-bestpractices" is a breaking change that must be documented in CHANGELOG.md. The full tool names are changing from "get_azure_bestpractices_" to "get-azure-bestpractices_" (note: the separator between area and command is underscore, but the area name itself now uses dashes).

This affects two tools:

• "get_azure_bestpractices_ai_app" → "get-azure-bestpractices_ai-app"
• "get_azure_bestpractices_get" → "get-azure-bestpractices_get"

The PR checklist specifically requires updating CHANGELOG.md for product changes. This breaking change should be added to the "## 2.0.0-beta.20 (Unreleased)" section under "### Breaking Changes".

Suggested change

	public string Name => "get-azure-bestpractices";
	public string Name => "get_azure_bestpractices";

[Copilot]

The area name change from "get_azure_bestpractices" to "get-azure-bestpractices" also affects the other command in this area. The "get" command's full tool name changes from "get_azure_bestpractices_get" to "get-azure-bestpractices_get".

The following files reference "get_azure_bestpractices_get" and need to be updated:

1. consolidated-tools.json (line 1074): "get_azure_bestpractices_get" → "get-azure-bestpractices_get"
2. prompts.json (line 553): Key "get_azure_bestpractices_get" → "get-azure-bestpractices_get"
3. e2eTestPrompts.md (lines 521-529): All references to "get_azure_bestpractices_get" → "get-azure-bestpractices_get"

These updates are necessary consequences of changing the area name, even though the command name itself ("get") is not changing.