Draft
Conversation
… Redis or Postgres)
9a497ee to
e41d678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for sovereign Azure clouds (China and US Government) across several services by making cloud-specific endpoint and scope selection dynamic. The changes add an explicit cloud type to the core authentication configuration and propagate this awareness through dependent services, ensuring correct endpoints and tokens are used for each cloud environment.
Key changes include:
Core authentication enhancements:
AzureCloudenum and a newCloudTypeproperty toAzureCloudConfiguration, updating its logic to parse and expose the current cloud environment. This is also reflected in theIAzureCloudConfigurationinterface. [1] [2] [3] [4]Cloud-aware endpoint and scope selection:
AppLensService,ProfilerDataService,AppServiceService, andConfidentialLedgerServiceto use the detected cloud type from the tenant service, dynamically selecting the correct endpoints and token scopes for public, China, and US Government clouds. This includes methods for resolving management, diagnostics, and CosmosDB endpoints. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]Service-specific improvements:
AppServiceService, CosmosDB connection string generation is now cloud-aware, ensuring correct domain suffixes for each environment.ConfidentialLedgerService, the ledger URI is now built with the appropriate domain for the current cloud.These changes collectively enable multi-cloud support, allowing the codebase to function correctly in Azure Public, China, and US Government environments.