flowey: don't leave the vhd download prompt open forever, timeout after 30s#3134
Open
chris-oo wants to merge 1 commit intomicrosoft:mainfrom
Open
flowey: don't leave the vhd download prompt open forever, timeout after 30s#3134chris-oo wants to merge 1 commit intomicrosoft:mainfrom
chris-oo wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Flowey node responsible for downloading OpenVMM VMM test artifacts to avoid blocking indefinitely on the local “press enter to confirm download” prompt by introducing a 30s timeout.
Changes:
- Add a 30-second timeout to the local interactive download confirmation prompt.
- Return an error if the prompt times out (instead of waiting forever).
Comment on lines
+231
to
+235
| if !skip_prompt { | ||
| let _ = std::io::stdin().read_line(&mut String::new()); | ||
| // Only display the prompt for 30s before timing | ||
| // out. | ||
| let (tx, rx) = std::sync::mpsc::channel(); | ||
|
|
There was a problem hiding this comment.
In non-interactive environments (stdin not a TTY), the prompt logic can still proceed immediately (read_line returns EOF) and start downloading without explicit user acceptance. Consider checking stdin().is_terminal() (or equivalent) here and failing with a message that the user must pass LocalOnlySkipDownloadPrompt/run in an interactive terminal.
Comment on lines
+242
to
+244
| let _ = rx | ||
| .recv_timeout(std::time::Duration::from_secs(30)) | ||
| .map_err(|_| anyhow!("timed out waiting for input after 30s"))?; |
There was a problem hiding this comment.
The value received from recv_timeout is an io::Result<usize> from read_line, but it’s currently ignored. If read_line returns Ok(0) (EOF) or Err(_), this should be treated as “no acceptance” and fail the step (rather than implicitly accepting and continuing).
Suggested change
| let _ = rx | |
| .recv_timeout(std::time::Duration::from_secs(30)) | |
| .map_err(|_| anyhow!("timed out waiting for input after 30s"))?; | |
| let read_result = rx | |
| .recv_timeout(std::time::Duration::from_secs(30)) | |
| .map_err(|_| anyhow!("timed out waiting for input after 30s"))?; | |
| match read_result { | |
| Ok(n) if n > 0 => { | |
| // User pressed enter; proceed. | |
| } | |
| Ok(0) => { | |
| // EOF before confirmation: treat as no acceptance. | |
| return Err(anyhow!( | |
| "stdin closed (EOF) before confirmation; aborting download" | |
| )); | |
| } | |
| Err(e) => { | |
| // Read error: treat as no acceptance. | |
| return Err(anyhow!( | |
| "failed to read confirmation from stdin: {e}" | |
| )); | |
| } | |
| } |
chris-oo
force-pushed
the
vhd-prompt-timeout
branch
from
a78eaf3 to
d0f6545
Compare
chris-oo
force-pushed
the
vhd-prompt-timeout
branch
from
d0f6545 to
7316980
Compare
smalis-msft
reviewed
Mar 26, 2026
smalis-msft
reviewed
Mar 26, 2026
flowey/flowey_lib_hvlite/src/download_openvmm_vmm_tests_artifacts.rs
Outdated
Show resolved
Hide resolved
chris-oo
force-pushed
the
vhd-prompt-timeout
branch
from
7316980 to
f70363d
Compare
chris-oo
force-pushed
the
vhd-prompt-timeout
branch
from
f70363d to
9314ed3
Compare
chris-oo
force-pushed
the
vhd-prompt-timeout
branch
from
9314ed3 to
a2ea837
Compare
smalis-msft
reviewed
Mar 31, 2026
chris-oo
force-pushed
the
vhd-prompt-timeout
branch
from
a2ea837 to
e6d14c9
Compare
smalis-msft
approved these changes
Mar 31, 2026
…er 30s feedback: use crossterm to read terminal input and poll just download if not interactive
benhillis
force-pushed
the
vhd-prompt-timeout
branch
from
e6d14c9 to
f6625f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior is really annoying when you start a terminal, or run it in an agent. Fail the download step after 30s if the user didn't accept, or if the user didn't ask to skip the prompt in the first place.