Skip to content

feat(firefox): roll to r1568 - #43703

Closed
microsoft-playwright-automation[bot] wants to merge 1 commit into
mainfrom
roll-into-pw-firefox/1568
Closed

microsoft-playwright-automation[bot] wants to merge 1 commit into
mainfrom
roll-into-pw-firefox/1568

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/80d50b285c001ea0b056afb52243ec223f766c39. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5189 passed, 614 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

3 flaky ⚠️ [playwright-test] › ui-mode-trace.spec.ts:388 › should reveal errors in the sourcetab `@playwright-x64-server2025-64-core-node22`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@chromium-playwright-x64-ubuntu24-64-core-node22`
⚠️ [webkit-library] › library/browsercontext-storage-state.spec.ts:751 › ST-019 should not leave IndexedDB connections open `@webkit-playwright-x64-ubuntu24-64-core-node22`

23573 passed, 706 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

1 fatal errors, not part of any test
15 failed
❌ [chromium-library] › library/defaultbrowsercontext-2.spec.ts:146 › DC-027 should goto about:blank on relaunched persistent context @msedge-dev-playwright-x64-server2025-64-core
❌ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:117 › CD-004 should connect when an existing page has been discarded @msedge-playwright-x64-server2025-64-core
❌ [chromium-library] › library/defaultbrowsercontext-2.spec.ts:146 › DC-027 should goto about:blank on relaunched persistent context @msedge-playwright-x64-server2025-64-core
❌ [chromium-library] › library/download.spec.ts:399 › download event › DO-022 should save downloads to artifactsDir @msedge-playwright-x64-server2025-64-core
❌ [chromium-library] › library/downloads-path.spec.ts:77 › downloads path › DO-042 should report downloads in downloadsPath folder with a relative path @msedge-playwright-x64-server2025-64-core
❌ [chromium-library] › library/downloads-path.spec.ts:91 › downloads path › DO-043 should accept downloads in persistent context @msedge-playwright-x64-server2025-64-core
❌ [chromium-library] › library/downloads-path.spec.ts:105 › downloads path › DO-044 should delete downloads when persistent context closes @msedge-playwright-x64-server2025-64-core
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:203 › ST-005 should round-trip OPFS @firefox-playwright-x64-server2025-64-core
❌ [webkit-library] › library/tracing.spec.ts:565 › TR-023 should produce screencast frames fit @webkit-playwright-x64-server2025-64-core
❌ [webkit-library] › library/tracing.spec.ts:565 › TR-023 should produce screencast frames scale @webkit-playwright-x64-server2025-64-core
❌ [android-page] › page/page-event-pageerror.spec.ts:20 › ER-001 should fire
❌ [android-page] › page/selectors-get-by.spec.ts:117 › SE-082 getByLabel should work with aria-labelledby
❌ [android-page] › page/selectors-get-by.spec.ts:122 › SE-083 getByLabel should prioritize aria-labelledby over native label
❌ [android-page] › page/selectors-get-by.spec.ts:140 › SE-086 getByLabel should prioritize aria-labelledby over aria-label
❌ [android-page] › page/selectors-role.spec.ts:436 › SE-060 should support name

35 flaky ⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:202 › CD-007 should write traces to provided artifactsDir on connectOverCDP `@chromium-playwright-x64-server2025-64-core`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@chromium-playwright-x64-server2025-64-core`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:202 › CD-007 should write traces to provided artifactsDir on connectOverCDP `@msedge-dev-playwright-x64-server2025-64-core`
⚠️ [chromium-library] › library/beforeunload.spec.ts:20 › BU-001 should close browser with beforeunload page `@chromium-macos-15-large`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:80 › CD-003 should connect when the opener of an existing page has no renderer `@chromium-macos-15-large`
⚠️ [chromium-library] › library/screencast.spec.ts:28 › SC-001 screencast.start delivers frames via onFrame callback `@chromium-macos-15-large`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:117 › CD-004 should connect when an existing page has been discarded `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1717 › TV-077 should highlight locator in iframe while typing `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:45 › CD-002 should connect when an existing page has no renderer `@msedge-playwright-x64-server2025-64-core`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:202 › CD-007 should write traces to provided artifactsDir on connectOverCDP `@msedge-playwright-x64-server2025-64-core`
⚠️ [chromium-library] › library/chromium/extensions.spec.ts:155 › MV3 › CR-040 should report console messages from content script `@msedge-playwright-x64-server2025-64-core`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/popup.spec.ts:279 › PO-028 should not throw when click closes popup `@chromium-ubuntu-22.04-node26`
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:87 › CG-100 should update aria snapshot highlight `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:202 › CG-157 should not print context options method override in xunit if no options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1937 › TV-087 should not leak recorders `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-reuse.spec.ts:200 › reuse connect › BC-076 should not cache resources `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:652 › ST-017 should roundtrip IndexedDB values and keys with setStorageState `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/har.spec.ts:198 › HA-012 should include form params `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/hit-target.spec.ts:158 › HT-007 should work with mui select `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:605 › cli codegen › CG-021 should check `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:65 › cli codegen › CG-041 should contain close page `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:586 › cli codegen › CG-076 should generate getByLabel `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:21 › CG-096 should generate aria snapshot `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:231 › CG-160 should work with --save-har and --save-har-glob in xunit `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:271 › CG-162 should print a valid basic program in nunit `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/inspector/cli-codegen-pytest.spec.ts:60 › CG-139 should work with --save-har `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/inspector/cli-codegen-python.spec.ts:135 › CG-127 should work with --save-har and --save-har-glob `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/inspector/pause.spec.ts:445 › pause › IN-023 should pause on page close `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/inspector/title.spec.ts:19 › IN-056 should reflect formatted URL of the page `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/selector-generator.spec.ts:185 › selector generator › GN-047 should escape text with quote `@firefox-playwright-x64-server2025-64-core`
⚠️ [firefox-library] › library/selector-generator.spec.ts:678 › selector generator › GN-096 should generate noText: no name from content `@firefox-playwright-x64-server2025-64-core`
⚠️ [webkit-library] › library/heap.spec.ts:304 › LE-014 cycle handles `@webkit-playwright-x64-server2025-64-core`
⚠️ [webkit-library] › library/tracing.spec.ts:565 › TR-023 should produce screencast frames crop `@webkit-playwright-x64-server2025-64-core`
⚠️ [webkit-page] › page/page-drag.spec.ts:177 › Drag and drop › DD-008 should respect the drop effect `@webkit-playwright-x64-server2025-64-core`

126901 passed, 4123 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 CI failures look pre-existing, not caused by this PR

Hi, I'm the Playwright bot. I compared the latest CI report with the diff and earlier CI results.

Details

All 15 failed test entries in the latest report have matching failures or failures rescued by retries before this PR, on the same projects and CI bots. The separate fatal error also occurred earlier on main. I refreshed the test-results database before checking the history.

This PR rolls Firefox from r1564 to r1568 and updates Firefox browser patches, preferences, and protocol declarations. It does not change Chromium, WebKit, or Android runtime code.

Pre-existing failures / flakes

  • Firefox on Windows: library/browsercontext-storage-state.spec.ts:203, ST-005 should round-trip OPFS, already timed out on the PR's base commit, f9a841f968dd, using Firefox r1564 (main run). It failed in 47 of 49 earlier runs on this Windows bot and passed in two. The Firefox roll reaches this test, but the failure predates it.

  • Edge / Edge Dev on Windows: DC-027 in library/defaultbrowsercontext-2.spec.ts (both channels), CD-004 in library/chromium/connect-over-cdp.spec.ts, DO-022 in library/download.spec.ts, and DO-042 through DO-044 in library/downloads-path.spec.ts account for seven entries. All seven also timed out in run 40346871090, commit 0a626efef020, before this PR. DO-022 and DO-042 passed on retry there; the other five entries failed after retries. This PR's Firefox download changes do not affect these Chromium tests.

  • WebKit on Windows: library/tracing.spec.ts:565, TR-023 should produce screencast frames fit and scale, have the same page.evaluate timeout in run 40600409279, commit 11f9e0269270, before this PR. They failed in 23/48 and 25/48 earlier runs respectively on this bot.

  • Android: ER-001 in page/page-event-pageerror.spec.ts, SE-082, SE-083, and SE-086 in page/selectors-get-by.spec.ts, and SE-060 in page/selectors-role.spec.ts all fail on the base-commit run. The errors match: stack-format differences, label lookup timeouts, and an empty accessible name. These are existing failures, not all intermittent flakes: ER-001 failed in all 97 earlier Android runs checked.

Pre-existing infrastructure error

  • The Windows Firefox job reports Worker teardown timeout of 30000ms exceeded outside any test. The same fatal worker-teardown error occurred in an earlier main job, commit b851907f34a7, with Firefox r1564. This is not a new error introduced by r1568.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant