chore: dev to main merge#91
Merged
Merged
Conversation
… capacity outputs
…definitions in main.bicep
fix: update roleDefinitionIdOrName for Event Hubs Data Sender to use GUID
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors infra/main.bicep to improve readability of conditional (ternary) expressions and increases reliability of Event Hubs role assignment by using the role definition GUID rather than the display name.
Changes:
- Reformatted multiple ternary expressions (parameter default and several outputs) across multiple lines for clarity.
- Replaced the Event Hubs role assignment from the role name to the role definition GUID.
- Minor formatting cleanup in tags (e.g., spacing in
Type: 'Non-WAF').
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Avijit-Microsoft
approved these changes
Jun 22, 2026
|
🎉 This PR is included in version 1.3.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes several improvements to the
infra/main.bicepfile, focusing on code readability and reliability. The main changes include reformatting conditional expressions for better clarity and replacing a role name with its corresponding GUID to ensure correct role assignment.Code readability improvements:
infra/main.bicep. [1] [2] [3]Reliability and correctness:
'Azure Event Hubs Data Sender'with its GUID'2b629674-e913-4c01-ae53-ef4638d8f975'in the Event Hub Namespace module to ensure correct role assignment, as using the GUID is more reliable and less prone to errors if the role name changes.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information