Skip to content

chore: dev to main merge#91

Merged
Avijit-Microsoft merged 9 commits into
mainfrom
dev
Jun 22, 2026
Merged

chore: dev to main merge#91
Avijit-Microsoft merged 9 commits into
mainfrom
dev

Conversation

@Saswato-Microsoft

Copy link
Copy Markdown
Collaborator

Purpose

This pull request makes several improvements to the infra/main.bicep file, focusing on code readability and reliability. The main changes include reformatting conditional expressions for better clarity and replacing a role name with its corresponding GUID to ensure correct role assignment.

Code readability improvements:

  • Reformatted multiple conditional expressions (ternary operators) to span multiple lines, making them easier to read and maintain. This affects parameter definitions and output assignments throughout infra/main.bicep. [1] [2] [3]

Reliability and correctness:

  • Replaced the string role name 'Azure Event Hubs Data Sender' with its GUID '2b629674-e913-4c01-ae53-ef4638d8f975' in the Event Hub Namespace module to ensure correct role assignment, as using the GUID is more reliable and less prone to errors if the role name changes.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors infra/main.bicep to improve readability of conditional (ternary) expressions and increases reliability of Event Hubs role assignment by using the role definition GUID rather than the display name.

Changes:

  • Reformatted multiple ternary expressions (parameter default and several outputs) across multiple lines for clarity.
  • Replaced the Event Hubs role assignment from the role name to the role definition GUID.
  • Minor formatting cleanup in tags (e.g., spacing in Type: 'Non-WAF').

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/main.bicep
@Avijit-Microsoft Avijit-Microsoft merged commit a027978 into main Jun 22, 2026
8 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.3.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants