debug: ensure breakpoint properties persist during updates (Fixes #239770) #243851
+83
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#239770 where updating a breakpoint's condition would cause previously set properties like logMessage to be lost. Modified updateBreakpoints to explicitly preserve existing values when they are not provided in the update data. Add test that verifies updateBreakpoints preserves properties correctly across updates.
Author
|
@microsoft-github-policy-service agree |
Author
|
@roblourens Hello! Have you had any time to take a look? Let me know if you need any changes, reviews, or a rebase/merge. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #239770 where updating a breakpoint's condition would cause previously set properties like logMessage to be lost.
The issue was that updateBreakpoints replaced the entire breakpoint state, causing properties like logMessage to be lost when updating a breakpoint's expression, for instance. My code suggestion altered updateBreakpoints to ensure properties are only overwritten if explicitly provided, by merging bpData with existing values.
I added a test to verify that updates correctly retain existing properties. The test sets an initial logMessage, sets a condition, modifies the condition, and verifies that logMessage remains unchanged.