-
Notifications
You must be signed in to change notification settings - Fork 36.7k
agent sessions - removal of history from chat view #278958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the chat history feature from the empty state chat view, eliminating the ability to display recent chat sessions in the welcome view when no conversation is active.
Key Changes
- Removed
chat.emptyState.history.enabledconfiguration option and related context keys - Deleted all history rendering code including list renderers, delegates, and UI components (300+ lines of CSS and TypeScript)
- Changed
product.defaultChatAgentfrom optional to required type, with direct property access in chatWidget.ts
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/constants.ts | Removed EmptyStateHistoryEnabled configuration constant |
| src/vs/workbench/contrib/chat/common/chatContextKeys.ts | Removed inEmptyStateWithHistoryEnabled context key |
| src/vs/workbench/contrib/chat/browser/media/chatViewWelcome.css | Removed 100+ lines of CSS for chat history UI components |
| src/vs/workbench/contrib/chat/browser/chatWidget.ts | Removed history list rendering logic, classes, and unused imports; simplified welcome view rendering |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Removed configuration registration for history feature |
| src/vs/workbench/contrib/chat/browser/actions/chatActions.ts | Removed history-related menu entries and toggle action |
| src/vs/platform/actions/common/actions.ts | Removed MenuId.ChatHistory menu identifier |
| src/vs/base/common/product.ts | Changed defaultChatAgent from optional to required property |
| .vscode/settings.json | Removed chat.emptyState.history.enabled workspace setting |
|
@bpasero red CI - I tried a retry and it didn't help |
|
Bring back the history icon as the history list is removed #267860 |
|
I am working on another change to bring the history back in form of the new agent sessions viewer, please be patient: #279303 The idea would be to allow to navigate sessions from there going forward and we will probably also have a picker experience at one point. |
No description provided.