Skip to content

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Nov 22, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 22, 2025 15:18
@bpasero bpasero self-assigned this Nov 22, 2025
Copilot finished reviewing on behalf of bpasero November 22, 2025 15:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the chat history feature from the empty state chat view, eliminating the ability to display recent chat sessions in the welcome view when no conversation is active.

Key Changes

  • Removed chat.emptyState.history.enabled configuration option and related context keys
  • Deleted all history rendering code including list renderers, delegates, and UI components (300+ lines of CSS and TypeScript)
  • Changed product.defaultChatAgent from optional to required type, with direct property access in chatWidget.ts

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vs/workbench/contrib/chat/common/constants.ts Removed EmptyStateHistoryEnabled configuration constant
src/vs/workbench/contrib/chat/common/chatContextKeys.ts Removed inEmptyStateWithHistoryEnabled context key
src/vs/workbench/contrib/chat/browser/media/chatViewWelcome.css Removed 100+ lines of CSS for chat history UI components
src/vs/workbench/contrib/chat/browser/chatWidget.ts Removed history list rendering logic, classes, and unused imports; simplified welcome view rendering
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Removed configuration registration for history feature
src/vs/workbench/contrib/chat/browser/actions/chatActions.ts Removed history-related menu entries and toggle action
src/vs/platform/actions/common/actions.ts Removed MenuId.ChatHistory menu identifier
src/vs/base/common/product.ts Changed defaultChatAgent from optional to required property
.vscode/settings.json Removed chat.emptyState.history.enabled workspace setting

@bpasero bpasero marked this pull request as ready for review November 23, 2025 13:12
@bpasero bpasero added this to the November 2025 milestone Nov 23, 2025
@joshspicer
Copy link
Member

@bpasero red CI - I tried a retry and it didn't help

@bpasero bpasero merged commit 335383f into main Nov 24, 2025
28 checks passed
@bpasero bpasero deleted the ben/swift-mite branch November 24, 2025 06:37
@MominRaza
Copy link

Bring back the history icon as the history list is removed #267860

@bpasero
Copy link
Member Author

bpasero commented Nov 25, 2025

I am working on another change to bring the history back in form of the new agent sessions viewer, please be patient: #279303

The idea would be to allow to navigate sessions from there going forward and we will probably also have a picker experience at one point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants