Skip to content

Simplify workspace members globs in Cargo.toml#4258

Merged
kennykerr merged 2 commits intomasterfrom
copilot/simplify-cargo-toml-members
Apr 22, 2026
Merged

Simplify workspace members globs in Cargo.toml#4258
kennykerr merged 2 commits intomasterfrom
copilot/simplify-cargo-toml-members

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 22, 2026

The workspace members list required manually adding a new glob pattern for every new subdirectory under crates/samples/ or crates/tests/, making it easy to forget and break new crates silently.

Replace the per-subdirectory globs with two-level wildcards so any new crate nested under these directories is picked up automatically:

members = [
    "crates/libs/*",
    "crates/samples/*/*",   # was 6 separate entries
    "crates/targets/*",
    "crates/tests/*/*",     # was 3 separate entries
    "crates/tools/*",
]

12 entries → 5. All 182 workspace packages remain resolved.

Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/e9c8517a-7a80-47fa-86a9-5e13f84b9fac

Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
@kennykerr kennykerr marked this pull request as ready for review April 22, 2026 15:02
@kennykerr kennykerr merged commit b8d3ac4 into master Apr 22, 2026
28 checks passed
@kennykerr kennykerr deleted the copilot/simplify-cargo-toml-members branch April 22, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants