Skip to content

feat: add option to disable file checks - #44

Merged
mightyiam merged 1 commit into
mightyiam:masterfrom
vidhanio:feat/optional-file-checks
Oct 9, 2026
Merged

mightyiam merged 1 commit into
mightyiam:masterfrom
vidhanio:feat/optional-file-checks

Conversation

@vidhanio

@vidhanio vidhanio commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

closes #43

@mightyiam mightyiam left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a theoretical future that will allow making this decision per-file, would files.check.enable be mutually exclusive with any per-file decitions?

@mightyiam

Copy link
Copy Markdown
Owner

I wonder why the check job is being skipped... would you be willing to look into that?

@vidhanio

vidhanio commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

i think we could have each file's check.enable default = config.checks.enable.

@vidhanio

vidhanio commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

@mightyiam it seems the ci in this repo only runs on push, not on pr. it ran on my repo: https://github.com/vidhanio/files/actions/runs/37952735205

@mightyiam
mightyiam force-pushed the feat/optional-file-checks branch from 71d6f0d to f54d020 Compare October 9, 2026 16:07
@mightyiam
mightyiam enabled auto-merge October 9, 2026 16:08
@mightyiam
mightyiam merged commit 458db3e into mightyiam:master Oct 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] provide option to disable adding flake checks

2 participants