Repository navigation
Stop returning the PAT in resource output - #17
Merged
mimachniak merged 1 commit intoOct 30, 2026
Merged
Conversation
All Get/Test/Set results of the native DSC v3 scripts and the Get() methods of the class-based resources echoed the personal access token, leaking it into dsc output, CI logs and reports. - Remove pat from all result objects (7 scripts, module classes) - Mark pat as writeOnly in the resource manifests - Drop pat from the schema's required list: dsc validates resource output against the schema, so a required pat would fail every call. The scripts still reject a missing PAT at runtime. - Add regression tests for the above - Fix invalid "(if ...)" expression in the native test setup that broke the local dsc download
Owner
|
thx for update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Get/Test/Set results of the native DSC v3 scripts and the Get() methods of the class-based resources echoed the personal access token, leaking it into dsc output, CI logs and reports.