feat: compose method skills within Trellis roles - #466
Draft
guanbear wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
method_skillsslots for brainstorm, implement, check, and debugglobal:<name>Agent Skills with canonical-path deduplication, boundary checks, visible diagnostics, and non-fatal fallbackWhy
Trellis should remain responsible for task state, planning artifacts, lifecycle gates, Git constraints, dispatch, verification, and reporting, while reusable Agent Skills contribute role-specific methods such as
grilling,tdd,codebase-design,code-review, anddiagnosing-bugs. This avoids copying third-party prompts or replacing Trellis roles and losing workflow guarantees.Behavior
Project-local references are directories relative to the repository root. Named global references resolve beneath
~/.agents/skills/. The first resolved method is primary, later methods are supporting, duplicate canonical paths are ignored, and invalid methods warn before Trellis continues with its built-in role.This first version deliberately does not install, download, pin, discover, or recursively resolve skills, and it does not allow an external skill to replace a complete Trellis workflow role.
Validation
py_compile: PASSgit diff --check: PASSThe repository's Vitest/typecheck commands could not run locally because dependencies were absent and the restricted environment could not reach the npm registry. The added Vitest integration suite is intended to run in CI.