revert: keep per-task workflow selection on beta - #504
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughPer-task workflow selection, persistence, CLI commands, and variant-library support were removed. Hooks and workflow-state injectors now read ChangesWorkflow source consolidation
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.trellis/spec/cli/backend/commands-workflow.md (1)
149-153: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win"Good" case doesn't actually test the hash-removal contract.
Using
--skip-allin the "Good" example leaves TDD content in place regardless of whether the workflow hash was removed — that flag skips updates outright. The "Bad" case correctly uses plaintrellis updateto show the contract failing; consider mirroring that in the "Good" case (plaintrellis updateafter correct hash removal) so the example actually demonstrates the intended protection.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.trellis/spec/cli/backend/commands-workflow.md around lines 149 - 153, The “Good” case in the workflow command documentation does not verify hash removal because trellis update --skip-all bypasses updates. Change that scenario to run plain trellis update after the TDD workflow replacement, preserving the expectation that TDD content remains because the workflow hash was correctly removed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.trellis/spec/cli/backend/commands-workflow.md:
- Around line 149-153: The “Good” case in the workflow command documentation
does not verify hash removal because trellis update --skip-all bypasses updates.
Change that scenario to run plain trellis update after the TDD workflow
replacement, preserving the expectation that TDD content remains because the
workflow hash was correctly removed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: eda94215-fe49-4268-86b9-fce88f1447c3
📒 Files selected for processing (41)
.claude/hooks/inject-workflow-state.py.claude/hooks/session-start.py.codex/hooks/inject-workflow-state.py.codex/hooks/session-start.py.cursor/hooks/session-start.py.opencode/plugins/inject-workflow-state.js.trellis/scripts/common/task_store.py.trellis/scripts/common/types.py.trellis/scripts/common/workflow_phase.py.trellis/scripts/common/workflow_selection.py.trellis/scripts/task.py.trellis/spec/cli/backend/commands-workflow.md.trellis/spec/cli/backend/workflow-state-contract.md.trellis/tasks/07-23-per-task-workflow/check.jsonl.trellis/tasks/07-23-per-task-workflow/design.md.trellis/tasks/07-23-per-task-workflow/implement.jsonl.trellis/tasks/07-23-per-task-workflow/implement.md.trellis/tasks/07-23-per-task-workflow/prd.md.trellis/tasks/07-23-per-task-workflow/task.json.trellis/workspace/tommy/index.md.trellis/workspace/tommy/journal-1.mdpackages/cli/src/cli/index.tspackages/cli/src/commands/workflow.tspackages/cli/src/templates/codex/hooks/session-start.pypackages/cli/src/templates/copilot/hooks/session-start.pypackages/cli/src/templates/opencode/plugins/inject-workflow-state.jspackages/cli/src/templates/shared-hooks/inject-workflow-state.pypackages/cli/src/templates/shared-hooks/session-start.pypackages/cli/src/templates/trellis/index.tspackages/cli/src/templates/trellis/scripts/common/task_store.pypackages/cli/src/templates/trellis/scripts/common/types.pypackages/cli/src/templates/trellis/scripts/common/workflow_phase.pypackages/cli/src/templates/trellis/scripts/common/workflow_selection.pypackages/cli/src/templates/trellis/scripts/task.pypackages/cli/test/commands/workflow.integration.test.tspackages/cli/test/scripts/inject-workflow-state-kiro.integration.test.tspackages/cli/test/templates/opencode.test.tspackages/core/src/task/records.tspackages/core/src/task/schema.tspackages/core/test/task/records.test.tspackages/core/test/task/schema.test.ts
💤 Files with no reviewable changes (22)
- .trellis/tasks/07-23-per-task-workflow/task.json
- .trellis/workspace/tommy/index.md
- .trellis/tasks/07-23-per-task-workflow/check.jsonl
- .trellis/tasks/07-23-per-task-workflow/prd.md
- .trellis/workspace/tommy/journal-1.md
- .trellis/tasks/07-23-per-task-workflow/design.md
- packages/cli/src/templates/trellis/scripts/common/workflow_selection.py
- packages/cli/src/templates/trellis/index.ts
- packages/core/test/task/records.test.ts
- .trellis/tasks/07-23-per-task-workflow/implement.jsonl
- .trellis/tasks/07-23-per-task-workflow/implement.md
- .trellis/scripts/common/types.py
- .trellis/scripts/common/workflow_selection.py
- packages/core/test/task/schema.test.ts
- packages/cli/src/cli/index.ts
- .trellis/scripts/task.py
- packages/cli/src/templates/trellis/scripts/common/task_store.py
- .trellis/scripts/common/task_store.py
- packages/cli/src/templates/trellis/scripts/common/types.py
- packages/cli/test/commands/workflow.integration.test.ts
- packages/cli/src/templates/trellis/scripts/task.py
- packages/cli/src/commands/workflow.ts
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Per-task workflow selection is a v0.7 beta capability. PR #467 independently targeted main, which would otherwise ship the beta-only feature in the next stable patch.
Validation
Summary by CodeRabbit
Workflow Management
workflow.md.trellis workflowno longer supports saving or listing saved workflow variants.Task Data
relatedFiles,notes, andmeta.Documentation / Tests