Skip to content

databricks docs update#11576

Merged
martyna-mindsdb merged 3 commits into
mainfrom
docs-databricks-update
Sep 17, 2025
Merged

databricks docs update#11576
martyna-mindsdb merged 3 commits into
mainfrom
docs-databricks-update

Conversation

@martyna-mindsdb

Copy link
Copy Markdown
Contributor

Description

databricks docs update

Fixes #issue_number

Type of change

  • 📄 This change is a documentation update

@entelligence-ai-pr-reviews

Copy link
Copy Markdown
Contributor

🔒 Entelligence AI Vulnerability Scanner

No security vulnerabilities found!

Your code passed our comprehensive security analysis.


@martyna-mindsdb martyna-mindsdb self-assigned this Sep 16, 2025
@martyna-mindsdb martyna-mindsdb added the documentation Documentation needs to be added or changed label Sep 16, 2025
@entelligence-ai-pr-reviews

Copy link
Copy Markdown
Contributor

Review Summary

🏷️ Draft Comments (2)

Skipped posting 2 draft comments that were valid but scored below your review threshold (>=13/15). Feel free to update them here.

mindsdb/utilities/render/sqlalchemy_render.py (2)

577-578: RIGHT JOIN is not supported and now raises NotImplementedError, but the code attempts to handle it as a join type, which will break queries using right joins.

📊 Impact Scores:

  • Production Impact: 4/5
  • Fix Specificity: 5/5
  • Urgency Impact: 3/5
  • Total Score: 12/15

🤖 AI Agent Prompt (Copy & Paste Ready):

In mindsdb/utilities/render/sqlalchemy_render.py, lines 577-578, the code now raises NotImplementedError for any join type containing 'RIGHT', which will break all right join queries. Remove 'or "RIGHT" in join_type' from the condition so that only 'ASOF' joins are blocked, and right joins are handled (or at least not blocked here).

581-588: Inefficient join type handling: repeated string comparisons and manual flags for join types (LEFT JOIN, FULL JOIN) can be replaced with a mapping for better scalability and maintainability.

📊 Impact Scores:

  • Production Impact: 2/5
  • Fix Specificity: 5/5
  • Urgency Impact: 1/5
  • Total Score: 8/15

🤖 AI Agent Prompt (Copy & Paste Ready):

Refactor the join type handling in mindsdb/utilities/render/sqlalchemy_render.py, lines 581-588. Replace the repeated string comparisons and manual flag assignments for join types (`LEFT JOIN`, `LEFT OUTER JOIN`, `FULL JOIN`) with a mapping dictionary that sets the `isouter` and `full` flags. This will improve maintainability and scalability as more join types are added.

@martyna-mindsdb martyna-mindsdb merged commit 7c205ae into main Sep 17, 2025
13 checks passed
@martyna-mindsdb martyna-mindsdb deleted the docs-databricks-update branch September 17, 2025 11:23
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Documentation needs to be added or changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants