Skip to content

docs -- updates to config file and env vars#11577

Merged
martyna-mindsdb merged 4 commits into
mainfrom
docs-disable-gui
Sep 18, 2025
Merged

docs -- updates to config file and env vars#11577
martyna-mindsdb merged 4 commits into
mainfrom
docs-disable-gui

Conversation

@martyna-mindsdb

Copy link
Copy Markdown
Contributor

Description

docs -- updates to config file and env vars

https://linear.app/mindsdb/issue/FQE-1475/doc-env-var-to-disable-gui

Fixes #issue_number

Type of change

  • 📄 This change is a documentation update

@martyna-mindsdb martyna-mindsdb self-assigned this Sep 16, 2025
@martyna-mindsdb martyna-mindsdb added the documentation Documentation needs to be added or changed label Sep 16, 2025
@entelligence-ai-pr-reviews

Copy link
Copy Markdown
Contributor

🔒 Entelligence AI Vulnerability Scanner

No security vulnerabilities found!

Your code passed our comprehensive security analysis.


StpMax
StpMax previously approved these changes Sep 16, 2025
Comment thread docs/setup/custom-config.mdx Outdated
```

```bash Python
python -m mindsdb --config=/path-to-the-extended-config-file/config.json

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be add --api=http,mysql to make it similar to docker command above?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. added it.

```

```bash Shell
export MINDSDB_CONFIG_PATH=/Users/username/path/config.json

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be add as next line command that run mindsdb? python -m mindsdb --api=http,mysql

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we do not add this for env vars. We focus on Docker here, as it is the recommended way for users.

@martyna-mindsdb

Copy link
Copy Markdown
Contributor Author

@StpMax
Can you please approve this again?

@entelligence-ai-pr-reviews

Copy link
Copy Markdown
Contributor

Review Summary

🏷️ Draft Comments (2)

Skipped posting 2 draft comments that were valid but scored below your review threshold (>=13/15). Feel free to update them here.

mindsdb/utilities/render/sqlalchemy_render.py (2)

577-578: RIGHT JOIN is not supported and now raises NotImplementedError, but the code does not handle RIGHT OUTER JOIN, which is a valid SQL join type and may be used in queries, causing unexpected failures.

📊 Impact Scores:

  • Production Impact: 2/5
  • Fix Specificity: 5/5
  • Urgency Impact: 2/5
  • Total Score: 9/15

🤖 AI Agent Prompt (Copy & Paste Ready):

In mindsdb/utilities/render/sqlalchemy_render.py, lines 577-578, the code currently checks for 'RIGHT' in join_type, which will also match 'BRIGHT JOIN' or similar, and does not explicitly handle 'RIGHT OUTER JOIN'. Update the check to only match 'RIGHT JOIN' and 'RIGHT OUTER JOIN' exactly, to avoid false positives and ensure unsupported join types are correctly handled.

581-588: Inefficient join type handling: repeated string comparisons and manual flags for join types (LEFT JOIN, FULL JOIN) can be replaced with a mapping for better scalability and maintainability.

📊 Impact Scores:

  • Production Impact: 1/5
  • Fix Specificity: 3/5
  • Urgency Impact: 1/5
  • Total Score: 5/15

🤖 AI Agent Prompt (Copy & Paste Ready):

Refactor the join type handling in mindsdb/utilities/render/sqlalchemy_render.py, lines 581-588. Replace the repeated string comparisons and manual flag assignments for join types with a mapping (dictionary) that maps join types to their corresponding 'isouter' and 'full' flags. This will improve scalability and maintainability as more join types are added.

@entelligence-ai-pr-reviews

Copy link
Copy Markdown
Contributor

Review Summary

@martyna-mindsdb martyna-mindsdb merged commit 039bacf into main Sep 18, 2025
13 checks passed
@martyna-mindsdb martyna-mindsdb deleted the docs-disable-gui branch September 18, 2025 11:33
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Documentation needs to be added or changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants