This repository was archived by the owner on Sep 12, 2026. It is now read-only.
fix(queries): stop selecting response_variable through the relationship - #662
Open
mosoriob wants to merge 1 commit into
Open
fix(queries): stop selecting response_variable through the relationship#662mosoriob wants to merge 1 commit into
mosoriob wants to merge 1 commit into
Conversation
thread_previews selected `response_variable { name }`. That relationship is
`foreign_key_constraint_on`, so it follows the constraint.
mintproject/monorepo#136 repoints the constraint to
modelcatalog_standard_variable, which has `label` and no `name`, and Hasura
then rejects the whole document at validation.
The fragment is pulled into problem_statement_info, so the failure is not
one empty field. The problem statement list, its get query and both
subscriptions all stop working.
Select the thread id instead. The fragment then validates on both sides of
that migration, so this app and the migration stop being a timed pair.
Verified live and anonymously against both endpoints. The new fragment
returns data from TACC, which is not migrated, and from the development
cluster, which is. The old fragment returns data from TACC and
validation-failed from the development cluster.
Cost: screens/modeling/actions.ts fills problem["preview"], the variable
chips on a problem statement card, from this selection. It already guards on
`th.response_variable && th.response_variable.name`, so it needs no change
and the array is now empty. At TACC 1 of 165 threads carries a response
variable, so 164 cards are unchanged.
Refs mintproject/monorepo#136, mintproject/monorepo#77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes this app work against the schema on both sides of
monorepo#136, so the migration and the
TACC deployment stop being a timed pair.
The problem
thread_previewsselectedresponse_variable { name }. That relationship isforeign_key_constraint_on, so it follows the constraint. monorepo#136 repoints theconstraint from
public.variabletomodelcatalog_standard_variable, which haslabelandno
name. Hasura then rejects the whole document at validation.The fragment is pulled into
problem_statement_info, so this is not one empty field. Theproblem statement list, its get query and both subscriptions all stop working. The commit
deployed at
mint.tacc.utexas.edutoday,888ec50, carries that selection.Verified live, anonymously, on both endpoints
graphql.mint.tacc.utexas.edu(not migrated)graphql.mint.local(migrated)maintodayvalidation-failedCost
One cosmetic item.
src/screens/modeling/actions.ts:361fillsproblem["preview"], thevariable chips on a problem statement card. It already guards on
th.response_variable && th.response_variable.name, so it needs no change and the array isnow empty. At TACC 1 of 165 threads carries a response variable, so 164 cards look the
same as before.
No codegen runs in this repo and the consumer is
any-typed, so nothing else needs updating.Why now
This is option C on monorepo#136. The
alternatives both leave a window with no working UI, and they break the rollback for the
React cutover (monorepo#77), which keeps
this app deployed-but-unrouted as its only undo.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QwQXq4Y3Tx8NoHpY1tYjEh