Repository navigation
Conversation
dinosaure
changed the title
hannesm
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Oct 15, 2026
CHANGES: - Prefer to use `typedef` internally when it's about C structs (@dinosaure, mirage/digestif#174) - Use `Int32.unsigned_compare` instead of `Int32.compare` (@dinosaure, mirage/digestif#175, mirage/digestif#176) - Fix overflow on our `xor` OCaml implementation (@dinosaure, mirage/digestif#177) - Do bounds checking on our `xor` C/OCaml implementation (@dinosaure, mirage/digestif#178, mirage/digestif#179) - Provide BLAKE2 implementation (@dinosaure, @thevilledev, mirage/digestif#180) - Optimize OCaml implementations of hash algorithms and unbox when we manipulate int32 values (@Zaneham, @dinosaure, mirage/digestif#181) - Expose Keyed version of `Make_BLAKE2{S,B}` (spotted by @copy, @dinosaure, mirage/digestif#173, mirage/digestif#182)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This execution path seems not executed at all by our hash algorithms (it seems that they xor on aligned data) but let's fix it. Find by scrutineer from @avsm.