Use proper request headers when opening URI. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refined user agent string, accept header, etc. Wrapper vulnerable library calls to avoid unhandled exception traps. Also allow for a logger to be passed in and used to track caught exceptions.
Collaborator
|
@ccgillett If this PR is still applicable, please resolve the conflicts and update. Also please add a test case so this can be detected in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes passing a more robust user agent string, accept header, etc. Wrapper vulnerable library
calls to avoid unhandled exception traps. Also allow for a logger to be
passed in and used to track caught exceptions.
Broad exception trapping is employed here to catch known issues with the Python TLS libraries for certain HTTPS situations.