Harden record parser helpers against offset+length overflow - #100
Open
Yeounui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. Thank you for this project.
The record parsing helpers do the bounds check as 'size >= offset + length'.
If an offset or length (both size_t) is very large, the sum can overflow and wrap around, so the check passes and the parser reads out of bounds.
Suggested fix: 'offset <= size && length <= size - offset'.
Not reachable from the packet path (record length is a checked uint16_t); this just guards the helpers against a caller passing a bad offset or length, e.g. from unchecked size_t arithmetic.
I also added a small CTest regression for a near-SIZE_MAX offset.