Expanding output object when using toHierarchy#104
Open
treygeorge wants to merge 2 commits intomjsarfatti:masterfrom
Open
Expanding output object when using toHierarchy#104treygeorge wants to merge 2 commits intomjsarfatti:masterfrom
treygeorge wants to merge 2 commits intomjsarfatti:masterfrom
Conversation
added 2 commits
September 13, 2013 19:19
Trying to make the final object output a little bit more useful by allowing the developer to define any data- attribute and have it added to the final object.
Removed the jquery each and opted for JS for instead. Also, some minor formatting polish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My team needed a bit more information on the objects that we were sorting. We did this through data attributes on the li's. We thought it would be real nice to add that information automatically to the output object on toHierarchy. We thought other people might think it convenient as well.
All we did for was add a $.each().data() loop on the item passed into "toHierarchy". We can then loop through the captured items and add them to the currentItem object as properties.
Loving nestedSortable so far. It is working really well for us. Thanks!