Skip to content

fix: guard IndexError in syllable separate() and remove debug prints - #2

Merged
mkpoli merged 1 commit into
masterfrom
fix/syllable-index-guard
Jul 20, 2026
Merged

fix: guard IndexError in syllable separate() and remove debug prints#2
mkpoli merged 1 commit into
masterfrom
fix/syllable-index-guard

Conversation

@mkpoli

@mkpoli mkpoli commented Jul 20, 2026

Copy link
Copy Markdown
Owner
  • import vibrato was unguarded at module level, crashing if the package wasn't installed
  • Class annotations MeCab.Tagger and janome.tokenizer.Tokenizer were evaluated at class-def time without from __future__ import annotations

Added from __future__ import annotations, wrapped vibrato import in try/except, and added _has_vibrato guard to VibratoTokenizer.__init__ matching the existing MeCab/Janome pattern.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@mkpoli, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 87bd3bae-3da6-4716-9f37-dc76bd7566f0

📥 Commits

Reviewing files that changed from the base of the PR and between be58ca7 and 89c7f55.

📒 Files selected for processing (2)
  • src/ainconv/conversion/katakana.py
  • src/ainconv/syllable.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/syllable-index-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mkpoli
mkpoli merged commit a18563a into master Jul 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant