Skip to content

feat(settings): full GUI parity with the config file - #42

Merged
mkpoli merged 1 commit into
masterfrom
feat/settings-gui-parity
Jun 27, 2026
Merged

feat(settings): full GUI parity with the config file#42
mkpoli merged 1 commit into
masterfrom
feat/settings-gui-parity

Conversation

@mkpoli

@mkpoli mkpoli commented Jun 27, 2026

Copy link
Copy Markdown
Owner

Fixes "the settings UI can't do the same thing as the config file." The dialog had 6 checkboxes and no way to express most options. Reworked to one control per config field, grouped under Input / Orthography / Suggestions:

  • Input: start-in-Latin, romaji-input-mode.
  • Orthography: a combobox for the 4-way tu_style (ト゚/ツ゚/トゥ/ツ), individual checkboxes for use_small_i/u/n, use_wi/we/wo, show_equals_boundary.
  • Suggestions: enabled, context-aware, and an edit field for max_candidates.

This drops the old "small glides" asymmetric-state workaround (each coda now has its own checkbox) and reaches full parity with the now self-documenting config.toml (#30 + #32). Clippy -D warnings clean on the MSVC target. Bumps 0.4.0.

Layout coordinates are hand-tuned and unverified visually — needs a Windows eyeball for spacing.

The settings dialog exposed only 6 checkboxes and couldn't represent the full
config (no way to pick among the four tu styles, the per-coda small-kana flags,
wi/we/wo, context-aware ranking, or max candidates) — so it couldn't do what the
file does, and the single 'small glides' checkbox needed an asymmetric-state
workaround.

Rework it to one control per option, grouped under Input / Orthography /
Suggestions frames: a combobox for the 4-way tu_style, individual checkboxes for
use_small_i/u/n and use_wi/we/wo and show_equals_boundary, an edit field for
max_candidates, and the input + suggestions toggles. Now at parity with the
self-documenting config.toml. Bumps to 0.4.0.
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@mkpoli, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 51 minutes and 30 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 591cb23e-247d-4f36-8088-25d9a3b42c5d

📥 Commits

Reviewing files that changed from the base of the PR and between 9ce950d and afe4da1.

📒 Files selected for processing (2)
  • Cargo.toml
  • src/settings_dialog.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/settings-gui-parity

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mkpoli
mkpoli merged commit 26561ac into master Jun 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant