Add byte-progress reporting for safetensors file loading#427
Open
aleroot wants to merge 1 commit into
Open
Conversation
Introduces LoadProgress and new loadArrays(url:stream:progressHandler:) and loadArraysAndMetadata(url:stream:progressHandler:) overloads that report bytes read as lazy arrays are evaluated. Uses a custom mlx_io_reader vtable backed by pread() so progress callbacks can be invoked from MLX worker threads. Includes a unit test verifying monotonic progress from 0 to 1.
Contributor
Author
|
This now depends on ml-explore/mlx#3742 , I will update this PR when that one is going to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds byte-level progress reporting for safetensors file loading so upper layers can drive precise model-loading progress UI.
This PR depends on ml-explore/mlx#3734.
The progress API in mlx-swift can report byte-level safetensors loading progress, but the truncated/failed-read correctness path needs the upstream MLX fix first. Without ml-explore/mlx#3734, CPU lazy-load read failures can be swallowed before they reach Swift.
Once ml-explore/mlx#3734 eventaully lands, I’ll update the MLX submodule reference here and rerun the mlx-swift test suite.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes