fixed naming conventions and used RecyclableMemoryStream instead of M… - #4
Open
01Vladimir10 wants to merge 1 commit into
Open
fixed naming conventions and used RecyclableMemoryStream instead of M…#401Vladimir10 wants to merge 1 commit into
01Vladimir10 wants to merge 1 commit into
Conversation
Owner
|
Just FYI, I'm looking at this. The pooled memory stream seems like a win (here and in the seekable-s3-stream code as well). |
|
I recommend getting a factory method in the constructor to create memory streams. Example: class MyClass
{
private readonly Func<MemoryStream> _streamFactory;
public MyClass(Func<MemoryStream> streamFactory = null)
{
_streamFactory = streamFactory ?? () => new MemoryStream();
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…emoryStream