Skip to content

Conversation

@simbig
Copy link
Contributor

@simbig simbig commented Nov 20, 2025

Summary

Implements automated smoke testing for all Storybook stories using @storybook/test-runner.

Changes

Testing Infrastructure

  • ✅ Added @storybook/test-runner with Playwright
  • ✅ Added test scripts to package.json
  • ✅ Integrated Storybook tests into validate command
  • ✅ Added test-storybook job to GitHub Actions workflow

Bug Fixes

  • 🐛 Fixed Tooltip story missing required date prop
  • 🐛 Fixed Button import issue (babel-plugin-import compatibility)
    • Changed from aliased import to direct ESM import
    • This fixed 12 failing stories: Button, Popover, Upload, Drawer, Modal, Space, Result, Input, Provider, Fields, ImageMap, Form

Test Results

All 57 story suites passing (121 tests total)

Test Suites: 57 passed, 57 total
Tests:       121 passed, 121 total
Time:        ~11 seconds

Test plan

CI will run all tests including the new Storybook smoke tests.

🤖 Generated with Claude Code

Simon Bigelmayr and others added 2 commits November 20, 2025 09:27
- Add @storybook/test-runner with Playwright
- Add test:storybook commands to package.json
- Add test-storybook job to GitHub Actions workflow
- Integrate Storybook tests into validate command
- Fix Tooltip story missing required date prop
- Fix Button import to bypass babel-plugin-import issue

All 57 story suites now pass smoke tests (121 tests total)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Eliminates duplicate Storybook build step, saving ~1m21s in CI.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@simbig simbig force-pushed the storybook-smoke-tests branch from 32e4c28 to 48b8813 Compare November 20, 2025 08:48
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@simbig simbig requested a review from spawnia November 20, 2025 08:53
@spawnia spawnia merged commit b768be0 into master Dec 3, 2025
6 checks passed
@spawnia spawnia deleted the storybook-smoke-tests branch December 3, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants