Repository navigation
Add COSMO example notebook for onboarding (#587) - #392
info-gallary wants to merge 12 commits into
Conversation
e27e1fe to
83b9421
Compare
|
Hi @sadamov , I’ve updated this PR to a COSMO example notebook as discussed. The notebook and changelog have been revised accordingly. Please let me know if any further changes are needed. |
There was a problem hiding this comment.
I think there was a misunderstanding here: the notebook for cosmo is already created. There are however some outstanding issues that need to be adressed, as mentioned in:
@info-gallary great, you will face one main obstacle. Currently the cosmo data is hosted on the ETH research collection and is multiple 100GB in size. so for a hello world example we will need to host a tiny piece of that data on a more accessible storage option, similar to DANRA. You might want to convert this .md file to a jupyter notebook. Here is my md file for cosmo: https://github.com/joeloskarsson/neural-lam-dev/blob/research/docs/reproduce_paper_sample.md
also #69 is mostly talking about danra, so you shouldn't close that issue with this PR.
So to rephrase, the issue about the COSMO hello world example is: how to bring the notebook from the research branch into main and get it to run in a reasonable amout of time. The preparation and hosting of a readuced cosmo sample is very much the core work. I do understand that hosting data is not simple/cheap, but it is required here. Since this PR is not solving the issues I'll mark it as draft for now.
If you would like to start working on the example data hosting I suggest to contact @leifdenby as he has some options from what I understand 😉
|
Thanks for the clarification, that makes sense. I understand now that the core missing work is preparing and hosting a reduced COSMO sample so the notebook can actually run in a reasonable time, rather than only converting the existing notebook into main. I’ll avoid closing #69 from this PR. I’d still be interested in helping with the reduced sample data preparation/hosting side. I’ll reach out to @leifdenby to better understand the available hosting options and what would be most useful here.
|
|
Okay I organized the hello_world issue and PRs:
If there was some oversight let me know, tried my best to look through all previous comms. |
|
Hi @sadamov and @leifdenby! I would love to help take this PR over the line by preparing and hosting the reduced COSMO sample dataset. If you can share a tiny slice of the real COSMO Zarr data (or point me to where I can access a small subset), I can structure it to match the notebook config and:
Let me know if this direction works, and I can start on this immediately! |
|
@GiGiKoneti let's give the current assigness a few days to respond.
|
|
@GiGiKoneti It looks like the original assignees are not active anylonger. Please comment here: #587 if you are still interested in finishing this work. |
|
Hi @sadamov, yes, I’m still interested in contributing. Apologies for the delayed response, I was tied up with other commitments and missed the update. I’m happy to collaborate with @GiGiKoneti and help with the COSMO notebook integration/testing once the reduced dataset is available on the DMI S3 storage. Please let me know where I can be most useful. |
I have the reduced COSMO Zarr sample and graph packaged and ready to link once the S3 storage is live. Once uploaded, it would be great to have your help validating the notebook execution and runtime benchmarks across CPU/GPU environments. |
|
Heads-up: we discussed the notebook format in the dev meeting and ran a poll in Slack afterwards, marimo won over Jupyter. Going forward notebooks in this repo are marimo For this PR that means: convert the notebook with Sorry for the churn, I know this lands mid-review. Let me know if smth is unclear or if you would rather I push the conversion to your branch. Specifically here: COSMO_example.ipynb to COSMO_example.py. Since #577 sets up the notebook CI, I suggest to sync with @Sharkyii so both notebooks run the same way. |
Describe your changes
This PR adds a new onboarding example notebook docs/notebooks/COSMO_example.ipynb that demonstrates the full Neural-LAM workflow (Datastore → Graph → Training → Evaluation → Visualization) using a COSMO-structured setup.
Key Improvements:
docs/notebooks/directory to follow the project's organizational patterns.HelloWorld.ipynbto avoid overlap with existing DANRA notebook work.Motivation:
The maintainers requested a COSMO-specific example to serve as the primary onboarding documentation, replacing the previous general "hello world" implementation.
Dependencies:
neural-lammllam-data-prep(demonstrated in config)weather-model-graphs(demonstrated in graph construction)numpy,xarray,pandas,torch,pyyamlIssue Link
closes #587
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Author checklist after completed review
COSMO_example.ipynbnotebook to documentation for onboardingChecklist for assignee