Repository navigation
fix(cli): correct plot_graph default config path and flag name - #761
Closed
nikhil3495 wants to merge 2 commits into
Closed
nikhil3495 wants to merge 2 commits into
nikhil3495 wants to merge 2 commits into
Conversation
The plot_graph CLI default config path did not exist and the --datastore_config_path flag was documented as a datastore config, while load_config_and_datastore requires the neural-lam config. Rename the flag to --config_path, point the default at the DANRA example config, keep the old flag as a deprecated alias, and let main() accept input_args so it can be tested. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Nikhil Bansiwal <nikhilbansiwal3495@gmail.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Nikhil Bansiwal <nikhilbansiwal3495@gmail.com>
Collaborator
|
the community is moving towards #83 and we decided not to invest more time into the plot_graph. closing this to save your time :) |
Contributor
Author
|
Thanks for letting me know, that makes sense. I'll look at #83 to see where I can help instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #760
Fix
python -m neural_lam.plot_graphfailing with default arguments.tests/datastore_examples/mdp/danra_100m_winds/config.yaml.--datastore_config_pathwas documented as a datastore config, butload_config_and_datastorerequires the neural-lam config. The flag is renamed to--config_path(matchingcreate_graphandtrain_model) with corrected help text.--datastore_config_pathremains as a deprecated alias that emits aDeprecationWarning.main()acceptsinput_argsso the CLI can be tested without patchingsys.argv.Tests: new tests in
tests/test_plot_graph.pycover the default path existing,--config_path, the deprecated alias, a missing-file error, and--help.pre-commitandpytest tests/test_plot_graph.pypass. The success path with the real DANRA config was not run end to end, since it needs the S3 test data and a generated graph.