Skip to content

Add basic unit tests for MainWindow #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ddennedy wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add basic unit tests for MainWindow #1825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21cbac3
Add basic unit tests for MainWindow
ddennedy May 9, 2026
b80567d
Apply suggestions from code review
ddennedy May 9, 2026
2234ab5
Enable test mode for QStandardPaths in MainWindow tests
ddennedy May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ endif()
add_subdirectory(CuteLogger)
add_subdirectory(src)
add_subdirectory(translations)
include(CTest)
if(BUILD_TESTING)
add_subdirectory(tests)
endif()

feature_summary(WHAT ALL INCLUDE_QUIET_PACKAGES FATAL_ON_MISSING_REQUIRED_PACKAGES)

Expand Down
2 changes: 1 addition & 1 deletion scripts/build-shotcut-msys2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ function set_globals {

#####
# shotcut
CONFIG[4]="cmake -G Ninja -D CMAKE_INSTALL_PREFIX=$FINAL_INSTALL_DIR -DCMAKE_PREFIX_PATH=$QTDIR -D SHOTCUT_VERSION=$SHOTCUT_VERSION $CMAKE_DEBUG_FLAG"
CONFIG[4]="cmake -G Ninja -D CMAKE_INSTALL_PREFIX=$FINAL_INSTALL_DIR -DCMAKE_PREFIX_PATH=$QTDIR -D SHOTCUT_VERSION=$SHOTCUT_VERSION -D BUILD_TESTING=OFF $CMAKE_DEBUG_FLAG"
CFLAGS_[4]="$ASAN_CFLAGS $CFLAGS"
LDFLAGS_[4]="$ASAN_LDFLAGS $LDFLAGS"
BUILD[4]="ninja -j $MAKEJ"
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-shotcut.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,7 @@ function set_globals {

#####
# shotcut
CONFIG[7]="cmake -G Ninja -D CMAKE_PREFIX_PATH=$QTDIR -D SHOTCUT_VERSION=$SHOTCUT_VERSION $CMAKE_DEBUG_FLAG"
CONFIG[7]="cmake -G Ninja -D CMAKE_PREFIX_PATH=$QTDIR -D SHOTCUT_VERSION=$SHOTCUT_VERSION -D BUILD_TESTING=OFF $CMAKE_DEBUG_FLAG"
if test "$TARGET_OS" = "Darwin" ; then
CONFIG[7]="${CONFIG[7]} -D CMAKE_INSTALL_PREFIX=."
CONFIG[7]="${CONFIG[7]} -D CMAKE_OSX_ARCHITECTURES='arm64;x86_64'"
Expand Down
44 changes: 23 additions & 21 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
find_package(Qt6 REQUIRED COMPONENTS Core)

add_executable(shotcut WIN32 MACOSX_BUNDLE
add_library(shotcut_objects OBJECT
abstractproducerwidget.cpp abstractproducerwidget.h
actions.cpp actions.h
autosavefile.cpp autosavefile.h
Expand Down Expand Up @@ -79,7 +79,6 @@ add_executable(shotcut WIN32 MACOSX_BUNDLE
jobs/screencapturejob.cpp jobs/screencapturejob.h
jobs/videoqualityjob.cpp jobs/videoqualityjob.h
jobs/whisperjob.cpp jobs/whisperjob.h
main.cpp
mainwindow.cpp mainwindow.h
mainwindow.ui
mltcontroller.cpp mltcontroller.h
Expand Down Expand Up @@ -233,6 +232,9 @@ add_executable(shotcut WIN32 MACOSX_BUNDLE
../icons/resources.qrc
)

add_executable(shotcut WIN32 MACOSX_BUNDLE main.cpp)
target_link_libraries(shotcut PRIVATE shotcut_objects)

add_custom_target(OTHER_FILES
SOURCES
../.github/ISSUE_TEMPLATE.md
Expand Down Expand Up @@ -266,8 +268,8 @@ add_custom_target(OTHER_FILES
../scripts/staple.sh
)

target_link_libraries(shotcut
PRIVATE
target_link_libraries(shotcut_objects
PUBLIC
CuteLogger
PkgConfig::mlt++
PkgConfig::FFTW
Expand All @@ -284,22 +286,22 @@ target_link_libraries(shotcut
Qt6::Xml
)
if(UNIX AND NOT APPLE)
target_link_libraries(shotcut PRIVATE Qt6::DBus X11::X11)
target_sources(shotcut PRIVATE linuxtools.cpp linuxtools.h)
target_link_libraries(shotcut_objects PUBLIC Qt6::DBus X11::X11)
target_sources(shotcut_objects PRIVATE linuxtools.cpp linuxtools.h)
endif()

file(GLOB_RECURSE QML_SRC "qml/*")
target_sources(shotcut PRIVATE ${QML_SRC})
target_sources(shotcut_objects PRIVATE ${QML_SRC})

target_include_directories(shotcut PRIVATE ${CMAKE_SOURCE_DIR}/CuteLogger/include)
target_compile_definitions(shotcut PRIVATE SHOTCUT_VERSION="${SHOTCUT_VERSION}")
target_include_directories(shotcut_objects PUBLIC ${CMAKE_SOURCE_DIR}/CuteLogger/include)
target_compile_definitions(shotcut_objects PUBLIC SHOTCUT_VERSION="${SHOTCUT_VERSION}")

# Add compile definitions when certain custom cache variables are ON
if(EXTERNAL_LAUNCHERS)
target_compile_definitions(shotcut PRIVATE EXTERNAL_LAUNCHERS)
target_compile_definitions(shotcut_objects PUBLIC EXTERNAL_LAUNCHERS)
endif()
if(USE_VULKAN)
target_compile_definitions(shotcut PRIVATE USE_VULKAN)
target_compile_definitions(shotcut_objects PUBLIC USE_VULKAN)
endif()

if(WIN32)
Expand All @@ -309,41 +311,41 @@ if(WIN32)
target_sources(shotcut PRIVATE ${CMAKE_SOURCE_DIR}/packaging/windows/shotcut.rc)

# Windows integration features
target_sources(shotcut PRIVATE windowstools.cpp windowstools.h)
target_sources(shotcut PRIVATE widgets/d3dvideowidget.h widgets/d3dvideowidget.cpp)
target_sources(shotcut PRIVATE widgets/openglvideowidget.h widgets/openglvideowidget.cpp)
target_link_libraries(shotcut PRIVATE d3d11 d3dcompiler ole32)
target_sources(shotcut_objects PRIVATE windowstools.cpp windowstools.h)
target_sources(shotcut_objects PRIVATE widgets/d3dvideowidget.h widgets/d3dvideowidget.cpp)
target_sources(shotcut_objects PRIVATE widgets/openglvideowidget.h widgets/openglvideowidget.cpp)
target_link_libraries(shotcut_objects PUBLIC d3d11 d3dcompiler ole32)

# Runtime exception handler for debug only
if(CMAKE_SYSTEM_PROCESSOR STREQUAL "AMD64")
target_include_directories(shotcut PRIVATE ${CMAKE_SOURCE_DIR}/drmingw/include)
target_link_directories(shotcut PRIVATE ${CMAKE_SOURCE_DIR}/drmingw/x64/lib)
target_include_directories(shotcut_objects PUBLIC ${CMAKE_SOURCE_DIR}/drmingw/include)
target_link_directories(shotcut_objects PUBLIC ${CMAKE_SOURCE_DIR}/drmingw/x64/lib)
target_link_libraries(shotcut PRIVATE debug exchndl)
endif()

if(WINDOWS_DEPLOY)
install(TARGETS shotcut RUNTIME DESTINATION ${CMAKE_INSTALL_PREFIX})
else()
target_compile_definitions(shotcut PRIVATE NODEPLOY)
target_compile_definitions(shotcut_objects PUBLIC NODEPLOY)
install(TARGETS shotcut RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
endif()

install(DIRECTORY qml DESTINATION ${CMAKE_INSTALL_PREFIX}/share/shotcut/)
install(DIRECTORY ${CMAKE_SOURCE_DIR}/filter-sets DESTINATION ${CMAKE_INSTALL_PREFIX}/share/shotcut/)
install(DIRECTORY ${CMAKE_SOURCE_DIR}/voices DESTINATION ${CMAKE_INSTALL_PREFIX}/share/shotcut/)
else()
target_sources(shotcut PRIVATE widgets/openglvideowidget.h widgets/openglvideowidget.cpp)
target_sources(shotcut_objects PRIVATE widgets/openglvideowidget.h widgets/openglvideowidget.cpp)
endif()

if(APPLE)
target_sources(shotcut PRIVATE macos.mm macos.h
target_sources(shotcut_objects PRIVATE macos.mm macos.h
widgets/metalvideowidget.h widgets/metalvideowidget.mm)
set_target_properties(shotcut PROPERTIES
OUTPUT_NAME "Shotcut"
MACOSX_BUNDLE_INFO_PLIST ${CMAKE_SOURCE_DIR}/packaging/macos/Info.plist.in)
find_library(FOUNDATION Foundation)
find_library(COCOA Cocoa)
target_link_libraries(shotcut PRIVATE ${FOUNDATION} ${COCOA})
target_link_libraries(shotcut_objects PUBLIC ${FOUNDATION} ${COCOA})
set(APP_ICON ${CMAKE_SOURCE_DIR}/packaging/macos/shotcut.icns)
target_sources(shotcut PRIVATE ${APP_ICON})
set_source_files_properties(${APP_ICON} PROPERTIES MACOSX_PACKAGE_LOCATION "Resources")
Expand Down
1 change: 1 addition & 0 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
add_subdirectory(mainwindow)
10 changes: 10 additions & 0 deletions tests/mainwindow/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
find_package(Qt6 REQUIRED COMPONENTS Test)

add_executable(test_mainwindow mainwindowtest.cpp)
target_link_libraries(test_mainwindow PRIVATE shotcut_objects Qt6::Test)
target_include_directories(test_mainwindow PRIVATE ${CMAKE_SOURCE_DIR}/src)

add_test(NAME MainWindowTest COMMAND test_mainwindow)
set_tests_properties(MainWindowTest PROPERTIES
ENVIRONMENT "QT_QPA_PLATFORM=offscreen"
)
Loading
Loading