Remove unsafety for uninitialized allocatr. Initialize with unusable space instead.#1486
Draft
qinsoon wants to merge 1 commit into
Draft
Remove unsafety for uninitialized allocatr. Initialize with unusable space instead.#1486qinsoon wants to merge 1 commit into
qinsoon wants to merge 1 commit into
Conversation
Member
Author
|
I will make binding side changes if we think this is a good idea. |
Collaborator
|
I think this solution is preferred over #1483 since we need to ensure that |
Collaborator
Alternatively, we can first investigate whether disallowing embedding See:
|
Member
Author
|
#1483 seems good to me. If it is merged, we can close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #1483.
&dyn Space. This requires changing bindings, as the layout of allocators are changed.