Skip to content

Log pause time with fractional milliseconds#1501

Open
qinsoon wants to merge 1 commit into
mmtk:masterfrom
qinsoon:log-pause-time-frac-millis
Open

Log pause time with fractional milliseconds#1501
qinsoon wants to merge 1 commit into
mmtk:masterfrom
qinsoon:log-pause-time-frac-millis

Conversation

@qinsoon

@qinsoon qinsoon commented May 26, 2026

Copy link
Copy Markdown
Member

elapsed.as_millis() truncates the value down to the nearest integral value (milliseconds). When the pause is short enough, the fractional part becomes significant. This PR switches the log to use floating-point millisecond values so short pauses can be displayed with sub-millisecond precision.

@qinsoon qinsoon requested a review from wks May 26, 2026 03:56

@wks wks left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants