feat: grant system campaign type decider role to PM administrator - #87
Open
mjfelis wants to merge 1 commit into
Open
feat: grant system campaign type decider role to PM administrator#87mjfelis wants to merge 1 commit into
mjfelis wants to merge 1 commit into
Conversation
10_PM_ADMINISTRATOR only had campaign-type-system-viewer (via campaign-all-viewer), so admins could not manage the discovery system campaign. Add campaign-type-system-decider to the administrator composite, matching the existing API and AD decider grants. Bump version to 2.83.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
10_PM_ADMINISTRATORcould not see or manage the discovery system campaign:CampaignService.listCampaignVOsgates the DISCOVERY campaign type on the explicitcampaign-type-system-*roles (IntrospectionService.getCampaignTypesWithRoles), and the administrator composite only carriedcampaign-type-system-viewerindirectly viacampaign-all-viewer.This adds
campaign-type-system-deciderto the10_PM_ADMINISTRATORcomposite inRoleUtil, matching the existingcampaign-type-api-decider/campaign-type-ad-decidergrants, so administrators can view, edit, and enable system campaigns (e.g. the boot-created "Sim Profile Discovery System Campaign").Version bumped to 2.83 (CI publishes on merge to main).
Deployment note
After pm-model picks up 2.83, set the
BOOLEAN_REGENERATE_KC_ROLESparameter to1soKeycloakAdminServicerebuilds the role composites in Keycloak, then re-login for the token to include the new role.