Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for “external” frontend modules (dropped under frontend/omni/src/modules/external-*) that can bring their own npm dependencies via pnpm workspace package discovery, and validates it with a light e2e test fixture.
Changes:
- Introduce a
pnpm-workspace.yamlsosrc/modules/external-*can be discovered as workspace packages, plus.gitignore/.npmrcadjustments to keep external modules out of git and avoid updating the root lockfile. - Add a Playwright light e2e test that copies in an external module fixture with its own
package.jsondependency and asserts it executes at runtime. - Update Biome schema references to 2.4.10 in frontend and full e2e configs and document the new workflow in README/CHANGELOG.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/omni/README.md | Documents how external modules are discovered and how dependency installation works. |
| frontend/omni/pnpm-workspace.yaml | Declares src/modules/external-* as workspace packages. |
| frontend/omni/CHANGELOG.md | Notes the new external-module dependency capability. |
| frontend/omni/biome.json | Updates Biome schema URL. |
| frontend/omni/.npmrc | Sets shared-workspace-lockfile=false to avoid root lockfile changes from external packages. |
| frontend/omni/.gitignore | Ignores src/modules/external-* directories. |
| e2e_tests/tests_omni_light/playwright.config.ts | Switches frontend startup to a dedicated script. |
| e2e_tests/tests_omni_light/scripts/run-frontend.sh | Copies the external module fixture, extends the manifest, installs/builds, and starts preview. |
| e2e_tests/tests_omni_light/scripts/extend-light-modules-json.mjs | Generates public/modules.json by extending the browser-only manifest with fixture module entries. |
| e2e_tests/tests_omni_light/src/external-module-dependency.spec.ts | New e2e assertion that an external module dependency is installed and executed. |
| e2e_tests/tests_omni_light/fixtures/external-module-test/package.json | External module fixture with its own dependency. |
| e2e_tests/tests_omni_light/fixtures/external-module-test/ExternalTestSidebarItem.svelte | Fixture UI module that triggers the service factory. |
| e2e_tests/tests_omni_light/fixtures/external-module-test/externalTestService.svelte.ts | Fixture service factory importing an external npm dependency. |
| e2e_tests/tests_omni_full/biome.json | Updates Biome schema URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.