Skip to content

use serialized http headers instead of raw #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
molocule wants to merge 2 commits into
base: richard/lossy-subrequest
Choose a base branch
from
Open

use serialized http headers instead of raw #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f323254
Update server.rs
molocule Aug 21, 2026
47980a7
Update server.rs
molocule Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pingora-core/src/protocols/http/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
use super::custom::server::Session as SessionCustom;
use super::error_resp;
use super::subrequest::server::HttpSession as SessionSubrequest;
use super::v1::client::http_req_header_to_wire;
use super::v1::server::HttpSession as SessionV1;
use super::v2::server::HttpSession as SessionV2;
use super::HttpTask;
Expand Down Expand Up @@ -471,11 +472,20 @@ impl Session {
}
}

/// Serialize the request header into HTTP/1.x wire format.
///
/// This serializes the parsed request header including any mutations
/// made by filters, rather than the raw bytes as read from the wire.
/// Whitespace is normalized.
pub fn to_h1_raw(&self) -> Bytes {
match self {
Self::H1(s) => s.get_headers_raw_bytes(),
Self::H1(s) => http_req_header_to_wire(s.req_header())
.expect("h1 request header always has a known version")
.freeze(),
Self::H2(s) => s.pseudo_raw_h1_request_header(),
Self::Subrequest(s) => s.get_headers_raw_bytes(),
Self::Subrequest(s) => http_req_header_to_wire(s.req_header())
.expect("subrequest header always has a known version")
.freeze(),
Self::Custom(c) => c.pseudo_raw_h1_request_header(),
}
}
Expand Down
Loading