Skip to content

Make Tool.Name required to match other protocol types #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 2 commits into from
Feb 23, 2026
+4 −3
Merged

Make Tool.Name required to match other protocol types #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b872f9a
Initial plan
Copilot Feb 21, 2026
6637361
Make Tool.Name required to match Prompt.Name, Resource.Name, Resource…
Copilot Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ModelContextProtocol.Core/Protocol/Tool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public sealed class Tool : IBaseMetadata
{
/// <inheritdoc />
[JsonPropertyName("name")]
public string Name { get; set; } = string.Empty;
public required string Name { get; set; }

/// <inheritdoc />
[JsonPropertyName("title")]
Expand Down
5 changes: 3 additions & 2 deletions tests/ModelContextProtocol.Tests/Protocol/ToolTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public static void Tool_HasCorrectJsonPropertyNames()
[Fact]
public static void ToolInputSchema_HasValidDefaultSchema()
{
var tool = new Tool();
var tool = new Tool { Name = "test" };
JsonElement jsonElement = tool.InputSchema;

Assert.Equal(JsonValueKind.Object, jsonElement.ValueKind);
Expand All @@ -119,7 +119,7 @@ public static void ToolInputSchema_HasValidDefaultSchema()
public static void ToolInputSchema_RejectsInvalidSchemaDocuments(string invalidSchema)
{
using var document = JsonDocument.Parse(invalidSchema);
var tool = new Tool();
var tool = new Tool { Name = "test" };

Assert.Throws<ArgumentException>(() => tool.InputSchema = document.RootElement);
}
Expand All @@ -133,6 +133,7 @@ public static void ToolInputSchema_AcceptsValidSchemaDocuments(string validSchem
using var document = JsonDocument.Parse(validSchema);
Tool tool = new()
{
Name = "test",
InputSchema = document.RootElement
};

Expand Down