Skip to content

Make LoggingMessageNotificationParams.Data required per MCP spec #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −9
Open

Make LoggingMessageNotificationParams.Data required per MCP spec #1353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
965135b
Initial plan
Copilot Feb 22, 2026
0db0364
Make LoggingMessageNotificationParams.Data required per MCP spec
Copilot Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/ModelContextProtocol.Core/Protocol/LoggingMessageNotificationParams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ public sealed class LoggingMessageNotificationParams : NotificationParams
public string? Logger { get; set; }

/// <summary>
/// Gets or sets the data to be logged, such as a string message.
/// Gets or sets the data to be logged, such as a string message or an object.
/// Any JSON serializable type is allowed here.
/// </summary>
[JsonPropertyName("data")]
public JsonElement? Data { get; set; }
public required JsonElement Data { get; set; }
}
4 changes: 1 addition & 3 deletions tests/ModelContextProtocol.Tests/Client/McpClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,11 +539,9 @@ public async Task AsClientLoggerProvider_MessagesSentToClient()
{
var m = await channel.Reader.ReadAsync(TestContext.Current.CancellationToken);
Assert.NotNull(m);
Assert.NotNull(m.Data);

Assert.Equal("TestLogger", m.Logger);

string? s = JsonSerializer.Deserialize<string>(m.Data.Value, McpJsonUtilities.DefaultOptions);
string? s = JsonSerializer.Deserialize<string>(m.Data, McpJsonUtilities.DefaultOptions);
Assert.NotNull(s);

if (s.Contains("Information"))
Expand Down
8 changes: 4 additions & 4 deletions tests/ModelContextProtocol.Tests/Protocol/LoggingMessageNotificationParamsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ public static void LoggingMessageNotificationParams_SerializationRoundTrip_Prese
Assert.NotNull(deserialized);
Assert.Equal(LoggingLevel.Warning, deserialized.Level);
Assert.Equal("MyApp.Services", deserialized.Logger);
Assert.NotNull(deserialized.Data);
Assert.Equal("Something went wrong", deserialized.Data.Value.GetString());
Assert.Equal("Something went wrong", deserialized.Data.GetString());
Assert.NotNull(deserialized.Meta);
Assert.Equal("value", (string)deserialized.Meta["key"]!);
}
Expand All @@ -34,7 +33,8 @@ public static void LoggingMessageNotificationParams_SerializationRoundTrip_WithM
{
var original = new LoggingMessageNotificationParams
{
Level = LoggingLevel.Error
Level = LoggingLevel.Error,
Data = JsonDocument.Parse("\"error occurred\"").RootElement.Clone(),
};

string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions);
Expand All @@ -43,7 +43,7 @@ public static void LoggingMessageNotificationParams_SerializationRoundTrip_WithM
Assert.NotNull(deserialized);
Assert.Equal(LoggingLevel.Error, deserialized.Level);
Assert.Null(deserialized.Logger);
Assert.Null(deserialized.Data);
Assert.Equal("error occurred", deserialized.Data.GetString());
Assert.Null(deserialized.Meta);
}
}